Update locking test #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| } catch (err) { | ||
| await installation1; | ||
| return; | ||
| await Promise.all([ installation1, installation2 ]); |
There was a problem hiding this comment.
I see that with this change the next test fails. Maybe because one of these promise is not yet completed?
A possible solution can be to use Promise.allSettled instead of Promise.all?
So that we are sure that all installation are completed and there aren't any pending installation.
What do you think?
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to hopefully fix some strange errors with the test for locking to prevent multiple parallel installations.
I have not been able to replicate the issue consistently but from what I saw during debugging the issue the test would sometimes not throw an error due to an absence of a lock file.
My hunch is that as there is no way to guarantee promises run in parallel sometimes the installation of the local plugin1 happens all at once in the await and so never conflicting with the "moment" plugin install.
This change makes it so both installs are in theory initiated at once and given that the moment install is more likely to yield in the event loop, more likely to then clash as the local plugin install starts.