Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds stub method for process.on #81

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

danieldelcore
Copy link
Contributor

https://nodejs.org/api/process.html

When LPM encounters a dependency using process.on like so:

image

It will throw the following error: typeerror: process.on is not a function

I'm not sure if this is a suitable enough stub method so feel free to let me know if there's a better way to handle it. 😄

Copy link
Owner

@davideicardi davideicardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

Could you just put a note in the README.md file about this limitation? Why it will be ignored ...

@danieldelcore
Copy link
Contributor Author

danieldelcore commented Jul 3, 2023

Sure thing! Done ✅

README.md Show resolved Hide resolved
@davideicardi davideicardi merged commit c395cb4 into davideicardi:master Jul 3, 2023
@danieldelcore danieldelcore deleted the process-on branch July 3, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants