Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashes when moving columns #33

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Fix crashes when moving columns #33

merged 2 commits into from
Mar 29, 2022

Conversation

davidfokkema
Copy link
Owner

@davidfokkema davidfokkema commented Mar 29, 2022

Instead of 'undoing' moving a column header and then reorder the data columns, keep track of the visual ordering of the logical columns. When saving, reorder the data in the saved project.

This included a hack which is causing crashes of Qt6. Probably Qt6 does not like it when a column is immediately moved back. I don't know.
@davidfokkema davidfokkema merged commit b372a92 into main Mar 29, 2022
@davidfokkema davidfokkema added the bug Something isn't working label Mar 29, 2022
@davidfokkema davidfokkema deleted the improve_table_view branch June 14, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant