Fixed recursion error when pyan.py is called in a directory with an __init__.py

[mao-liu]

If running pyan.py in a directory which contains an __init__.py, a recursion error occurs inside get_module_name with get_module_name('') recursively calling itself.

e.g. for the following folder structure:

foo/
    __init__.py
    bar.py
__init__.py

with the following call in the root directory:
python pyan.py foo/*.py --dot

get_module_name then gets called with the following arguments:

get_module_name('foo/bar.py')
--> get_module_name('foo')        # 1. this step should return 'foo' rather than recurse
    --> get_module_name('')
        -->get_module_name('')    # 2. recursion error
            ...

Existing behaviour is 2. New behaviour is 1.

[davidfraser]

Thanks for catching this!

[davidfraser]

After merging this, I noticed certain cases (such as a function in the __init__ file) where an empty string would be generated in the dotfile. We should really have test cases for this, but in the mean time it would be good to handle that a bit better. Would you be interested in working that out?

[mao-liu]

Interesting. I have not looked too closely at how it behaves with functions in __init__.py. I will be using this tool to review another repo with functions in __init__.py, I will try to write a fix when I do that review.

…

On Tue., 13 Dec. 2016 at 2:23 am, David Fraser ***@***.***> wrote: After merging this, I noticed certain cases (such as a function in the __init__ file) where an empty string would be generated in the dotfile. We should really have test cases for this, but in the mean time it would be good to handle that a bit better. Would you be interested in working that out? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABmyXA5GjpdPO0vxMcZmUDB88Q23rfCFks5rHWbhgaJpZM4LHTfJ> .

[davidfraser]

I've pushed a fix, and a testcase (not a proper running unit test yet):

cd testcase
../pyan.py --dot *.py foo/*.py > x.dot