Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor "if False: # TYPE_CHECKING" #1472

Closed
blueyed opened this issue Jan 10, 2020 · 3 comments
Closed

Honor "if False: # TYPE_CHECKING" #1472

blueyed opened this issue Jan 10, 2020 · 3 comments

Comments

@blueyed
Copy link
Contributor

blueyed commented Jan 10, 2020

pytest does not use if TYPE_CHECKING, but if False: # TYPE_CHECKING, recommended by flake8:

TYP001 guard import by if False: # TYPE_CHECKING: TYPE_CHECKING (not in 3.5.0, 3.5.1)

I think it would be good if Jedi would handle those comments (maybe requiring the exact comment).

The alternative would be trying to import it from typing_extensions I guess, but that would require code changes to pytest. The other alternative is dropping support for Python < 3.5.2, which will eventually be done, of course.

(via pytest-dev/pytest#6434)

Related Jedi issue: #1127
@blueyed blueyed mentioned this issue Jan 10, 2020
Merged
@davidhalter
Copy link
Owner

Why does pytest use this and not just the variable?

@blueyed
Copy link
Contributor Author

blueyed commented Jan 10, 2020

To support Python 3.5.0/3.5.1 I assume.

@davidhalter
Copy link
Owner

Makes sense.

It's just that I already started removing support for some things for 3.5. So 3.6 is really the target for Jedi to support. 3.5 is going to be end of life in 10 months :)

So I guess I'm closing, because this will solve itself in a few months.

@blueyed blueyed mentioned this issue Jan 10, 2020
Merged
2 tasks
blueyed added a commit to blueyed/pytest that referenced this issue Jan 10, 2020
@blueyed
Use TYPE_CHECKING instead of False
66d42ef 
This allows for e.g. Jedi to infer types.

It was only used to support Python 3.5.0/3.5.1, where this is available
in `typing_extensions`.

Ref: davidhalter/jedi#1472
blueyed added a commit to blueyed/pytest that referenced this issue Jan 10, 2020
@blueyed
Use TYPE_CHECKING instead of False
fcb9ca5 
This allows for e.g. Jedi to infer types.

It was only used to support Python 3.5.0/3.5.1, where this is available
in `typing_extensions`.

Ref: davidhalter/jedi#1472
blueyed added a commit to blueyed/pytest that referenced this issue Jan 11, 2020
@blueyed
Use TYPE_CHECKING instead of False
a775353 
This allows for e.g. Jedi to infer types.

It was only used to support Python 3.5.0/3.5.1, where this is available
in `typing_extensions`.

Ref: davidhalter/jedi#1472
blueyed added a commit to blueyed/pytest that referenced this issue Jan 14, 2020
@blueyed
Use TYPE_CHECKING instead of False
f0c6afa 
This allows for e.g. Jedi to infer types.

It was only used to support Python 3.5.0/3.5.1, where this is available
in `typing_extensions`.

Ref: davidhalter/jedi#1472
blueyed added a commit to blueyed/pytest that referenced this issue Jan 14, 2020
@blueyed
Use TYPE_CHECKING instead of False
7725f48 
This allows for e.g. Jedi to infer types.

It was only used to support Python 3.5.0/3.5.1, where this is available
in `typing_extensions`.

Ref: davidhalter/jedi#1472
blueyed added a commit to blueyed/pytest that referenced this issue Jan 14, 2020
@blueyed
Use TYPE_CHECKING instead of False
8c29b72 
This allows for e.g. Jedi to infer types.

It was only used to support Python 3.5.0/3.5.1, where this is available
in `typing_extensions`.

Ref: davidhalter/jedi#1472
blueyed added a commit to blueyed/pytest that referenced this issue Jan 14, 2020
@blueyed
Use TYPE_CHECKING instead of False
7d38dea 
This allows for e.g. Jedi to infer types.

It was only used to support Python 3.5.0/3.5.1, where this is available
in `typing_extensions`.

Ref: davidhalter/jedi#1472
blueyed added a commit to blueyed/pytest that referenced this issue Jan 15, 2020
@blueyed
Use TYPE_CHECKING instead of False
9cb3b66 
This allows for e.g. Jedi to infer types.

It was only used to support Python 3.5.0/3.5.1, where this is available
in `typing_extensions`.

Ref: davidhalter/jedi#1472
blueyed added a commit to blueyed/pytest that referenced this issue Jan 15, 2020
@blueyed
Use TYPE_CHECKING instead of False
77faa6a 
This allows for e.g. Jedi to infer types.

It was only used to support Python 3.5.0/3.5.1, where this is available
in `typing_extensions`.

Ref: davidhalter/jedi#1472
blueyed added a commit to blueyed/pytest that referenced this issue Jan 15, 2020
@blueyed
Use TYPE_CHECKING instead of False
12fc00c 
This allows for e.g. Jedi to infer types (it checks the name).

It was only used to support Python 3.5.0/3.5.1, where this is is not
available in the `typing` module.

Ref: davidhalter/jedi#1472

Put at the top to work around circular import.
blueyed added a commit to blueyed/pytest that referenced this issue Jan 15, 2020
@blueyed
Use TYPE_CHECKING instead of False
444e8a9 
This allows for e.g. Jedi to infer types (it checks the name).

It was only used to support Python 3.5.0/3.5.1, where this is is not
available in the `typing` module.

Ref: davidhalter/jedi#1472

Put at the top to work around circular import.
blueyed added a commit to blueyed/pytest that referenced this issue Jan 16, 2020
@blueyed
Use TYPE_CHECKING instead of False
25b8d18 
This allows for e.g. Jedi to infer types (it checks the name).

It was only used to support Python 3.5.0/3.5.1, where this is is not
available in the `typing` module.

Ref: davidhalter/jedi#1472

Put at the top to work around circular import.
blueyed added a commit to blueyed/pytest that referenced this issue Jan 16, 2020
@blueyed
Use TYPE_CHECKING instead of False
4d2a346 
This allows for e.g. Jedi to infer types (it checks the name).

It was only used to support Python 3.5.0/3.5.1, where this is is not
available in the `typing` module.

Ref: davidhalter/jedi#1472

Put at the top to work around circular import.
blueyed added a commit to blueyed/pytest that referenced this issue Jan 16, 2020
@blueyed
Use TYPE_CHECKING instead of False
663d572 
This allows for e.g. Jedi to infer types (it checks the name).

It was only used to support Python 3.5.0/3.5.1, where this is is not
available in the `typing` module.

Ref: davidhalter/jedi#1472

Uses `TYPE_CHECKING = False` in `_pytest.outcomes` to avoid having to
work around circular import.
blueyed added a commit to blueyed/pytest that referenced this issue Jan 16, 2020
@blueyed
Use TYPE_CHECKING instead of False
9cbf242 
This allows for e.g. Jedi to infer types (it checks the name).

It was only used to support Python 3.5.0/3.5.1, where this is is not
available in the `typing` module.

Ref: davidhalter/jedi#1472

Uses `TYPE_CHECKING = False` in `_pytest.outcomes` to avoid having to
work around circular import.
blueyed added a commit to blueyed/pytest that referenced this issue Jan 16, 2020
@blueyed
Use TYPE_CHECKING instead of False
4630e27 
This allows for e.g. Jedi to infer types (it checks the name).

It was only used to support Python 3.5.0/3.5.1, where this is is not
available in the `typing` module.

Ref: davidhalter/jedi#1472

Uses `TYPE_CHECKING = False` in `_pytest.outcomes` to avoid having to
work around circular import.
@charliermarsh charliermarsh mentioned this issue Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blueyed @davidhalter