Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix autocomplete crash in ycmd #1870

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Conversation

Presburger
Copy link
Contributor

Signed-off-by: Yusheng.Ma Yusheng.Ma@zilliz.com

Signed-off-by: Yusheng.Ma <Yusheng.Ma@zilliz.com>
@davidhalter
Copy link
Owner

I like the change. Is there a way we can test that?

@codecov-commenter
Copy link

Codecov Report

Merging #1870 (f5faca0) into master (7ff0d2d) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #1870      +/-   ##
==========================================
- Coverage   94.48%   94.48%   -0.01%     
==========================================
  Files          80       80              
  Lines       11847    11851       +4     
==========================================
+ Hits        11194    11197       +3     
- Misses        653      654       +1     
Impacted Files Coverage Δ
jedi/inference/gradual/stub_value.py 98.50% <50.00%> (-1.50%) ⬇️
jedi/inference/value/klass.py 98.17% <50.00%> (-0.45%) ⬇️
jedi/plugins/pytest.py 95.00% <0.00%> (+0.83%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@davidhalter
Copy link
Owner

I'm too lazy to write the test, but I want this fixed either way, so I'm merging. Would still make me happy if someone wrote a test about that. Thanks anyway!

@davidhalter davidhalter merged commit 3475ccf into davidhalter:master Nov 11, 2022
@Presburger
Copy link
Contributor Author

Presburger commented Feb 9, 2023

I'm too lazy to write the test, but I want this fixed either way, so I'm merging. Would still make me happy if someone wrote a test about that. Thanks anyway!

I'm find this bug in my vim's logs, It is hard to write a test about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants