Makes CallSignature.call_signature() #780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is same result as in docstring, ie method .doc, ie property. So it is with "self" -i dont like it, but no other way, easy.
|
Tests? I'm not sure about the naming yet, but agree that we should have something like this. |
|
Was wrong test, now its fixed |
davidhalter
approved these changes
Sep 26, 2016
| assert len(signatures) <= 1 | ||
|
|
||
| if signatures: | ||
| assert signatures[0].call_signature == expected_string |
There was a problem hiding this comment.
There should be an
else:
assert expected_string is None
there.
The test below is probably running into this.
|
it is fixed. |
|
Sorry for taking so long on this, but I didn't like what we came up with as the API together. It took a long time to develop another one, because the old internals didn't support what we were doing at the time. Now there's `[signature.to_string() for signature in definition.get_signatures()]. Thanks for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is same result as in docstring, ie method .doc, ie property. So it is with "self" (for methods) -i dont like it, but no other way, easy.