Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #224: Remove Potential Malicious Link in Parso's Acknowledgement README.rst #225

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

nilbest
Copy link
Contributor

@nilbest nilbest commented Jun 27, 2024

Description

This pull request addresses issue #224 by removing the potentially malicious link from the Acknowledgements section of the README.rst. The link in question was flagged by internal IT as suspicious and has been excluded to ensure the safety and integrity of the parso package.

Additional Research:

  • I'm not a security specialist, but a quick who.is search on the domain provided limited information.
    who is_diagnostics
    who is_DNS_Records
    who is_search

Changes Made:

Verification:

Since it appears that the METADATA file may be generated from the README.rst during the installation process, it is expected that the link will no longer appear in the METADATA file after installing the updated version of parso. To verify this, please install the updated package in a virtual environment and confirm that the METADATA file does not contain the removed link.

Additional Notes:

  • The link was removed from the README.rst with the expectation that it will not be present in the generated METADATA file.
  • If there are any concerns or if further validation is needed, please let me know.

Reviewers:

@davidhalter - Could you please review these changes?

Thank you for your attention to this matter.

@davidhalter
Copy link
Owner

Thanks, that makes sense!

@davidhalter davidhalter merged commit 1ca6b1f into davidhalter:master Jun 27, 2024
7 of 8 checks passed
@davidhalter
Copy link
Owner

Because I'm interested: What tools did you use to find this? Was this something internal? What was the company? Feel free to write here or email me whatever information you're allowed to share.

@nilbest
Copy link
Contributor Author

nilbest commented Jun 28, 2024 via email

@nilbest
Copy link
Contributor Author

nilbest commented Jun 28, 2024

Also, do you know if we fixed this now in the main branch, would it automatically be included in the newer version of this repo?

I only installed ipykernel and got this repo in version 0.8.4 with the bad link.
(Followed this guide:
https://docs.jupyter.org/en/latest/install/kernels.html
And got to this install instructions:
https://ipython.readthedocs.io/en/latest/install/kernel_install.html)

I looked into ipykernel dependency but they do not mention this repo so it may be included in one of the other mentioned repos in ipykernel.
Link to the ipykernel pyproject.toml for dependencies:
https://github.com/ipython/ipykernel/blob/main/pyproject.toml

Maybe you know more about where this repo may be included and if so would it be the last updated version without this link, so that the security wouldn't trigger again…
If not I may have to dig a bit more to get to the install call of this repo to fix this…

(if I get the time in the next few days)

@davidhalter
Copy link
Owner

Hi Niels

This will probably keep happening if you use the currently released parso. Your change is now on master branch, but not released on PyPI. If you want to use the version with the fix, you can install parso like this: https://parso.readthedocs.io/en/latest/docs/installation.html#from-git. If you use it with Jupyter you can probably just install parso first and then the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants