Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(csharp/Drivers/Apache): add implementation for Statement.ExecuteUpdate for Spark #7

Merged
merged 15 commits into from
Mar 21, 2024

Conversation

birschick-bq
Copy link
Collaborator

@birschick-bq birschick-bq commented Mar 20, 2024

Implements Statement.ExecuteUpdate (synchronous call)

  • Returns number of affected rows or -1 if not rows are affected.
  • Ensures affected/inserted column exist and are of the correct data type before using.
  • Unit test that uses SparkData.sql to test various update statements.

Note: Contains some side changes (projects, SparkConnection.cs) that were causing some failures in tests.

Copy link

⚠️ Please follow the Conventional Commits format in CONTRIBUTING.md for PR titles.

@birschick-bq birschick-bq changed the title Implement Statement.ExecuteUpdate with single test to verify. feat(csharp/Drivers/Apache): Implement Statement.ExecuteUpdate for Spark Mar 20, 2024
@birschick-bq birschick-bq changed the title feat(csharp/Drivers/Apache): Implement Statement.ExecuteUpdate for Spark feat(csharp/Drivers/Apache): add implementation for Statement.ExecuteUpdate for Spark Mar 21, 2024
@davidhcoe davidhcoe merged commit 6dca25c into dev/apache-drivers Mar 21, 2024
11 checks passed
@birschick-bq birschick-bq deleted the dev/birschick-bq/execute-update branch April 15, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants