Skip to content

Commit

Permalink
fix: remove Firefox from e2e tests because of flake
Browse files Browse the repository at this point in the history
  • Loading branch information
David Horm committed Apr 2, 2023
1 parent 17644b5 commit 909a790
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 16 deletions.
10 changes: 0 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,3 @@ These are the other scripts defined in `package.json`.
| `pnpm test:e2e` | Run end-to-end tests (can add `--headed` and/or `--debug`) |
| `pnpm codegen` | Generate end-to-end tests with codegen |
| `pnpm run deploy` | Deploy to Github pages |

FYI - when running Playwright end-to-end tests, there may be flakey firefox-specific tests:

```
page.goto: NS_ERROR_CONNECTION_REFUSED
=========================== logs ===========================
navigating to "http://localhost:5173/", waiting until "load"
```

This maybe an only Windows problem. Workaround is to execute end-to-end tests with just Chrome: `pnpm test -- --project=chromium`
13 changes: 7 additions & 6 deletions playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,13 @@ const config: PlaywrightTestConfig = {
},
},

{
name: "firefox",
use: {
...devices["Desktop Firefox"],
},
},
// Tests in Firefox seems to be flakey
// {
// name: "firefox",
// use: {
// ...devices["Desktop Firefox"],
// },
// },

{
name: "webkit",
Expand Down

0 comments on commit 909a790

Please sign in to comment.