Merge pull request #936 from lukesmurray/style-strings

check for number before adding px to styles
davidjbradshaw · Apr 26, 2021 · 3f84a35 · 3f84a35
2 parents 72cce22 + 858c487
commit 3f84a35
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/src/iframeResizer.js b/src/iframeResizer.js
@@ -936,18 +936,19 @@
     )
   }
 
+  function isNumber(value) {
+    return typeof value === 'number'
+  }
+
   function setupIFrame(iframe, options) {
     function setLimits() {
       function addStyle(style) {
-        if (
-          Infinity !== settings[iframeId][style] &&
-          0 !== settings[iframeId][style]
-        ) {
-          iframe.style[style] = settings[iframeId][style] + 'px'
-          log(
-            iframeId,
-            'Set ' + style + ' = ' + settings[iframeId][style] + 'px'
-          )
+        var styleValue = settings[iframeId][style]
+        if (Infinity !== styleValue && 0 !== styleValue) {
+          iframe.style[style] = isNumber(styleValue)
+            ? styleValue + 'px'
+            : styleValue
+          log(iframeId, 'Set ' + style + ' = ' + iframe.style[style])
         }
       }