Issue1: Avoid repeated calculation of SumOfRolesCount (#59)

davidlang42 · Dec 11, 2023 · 955defb · 955defb
1 parent 667dfc5
commit 955defb
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/Desktop/ViewModels/ShowRootOrSectionView.cs b/Desktop/ViewModels/ShowRootOrSectionView.cs
@@ -103,10 +103,11 @@ public string[] CountErrorBackgroundColors
         {
             get
             {
+                uint[]? sum_of_roles_count = null;
                 var colors = new string[castGroups.Length];
                 for (var i = 0; i < colors.Length; i++)
                     if (CountByGroups[i].Count is uint required_count
-                        && SumOfRolesCount[i] != required_count)
+                        && (sum_of_roles_count ??= SumOfRolesCount)[i] != required_count) // avoid repeated calculation of SumOfRolesCount, but also only calculate if needed
                         colors[i] = HighlightError.ERROR_COLOR;
                     else
                         colors[i] = HighlightError.TEXTBOX_COLOR;