Issue26: Various cast selection bugs

Desktop/Converters/SparseCountByGroups.cs

@@ -1,6 +1,7 @@
 using Carmen.Desktop.ViewModels;
 using Carmen.ShowModel.Applicants;
 using Carmen.ShowModel.Structure;
+using Carmen.ShowModel;
 using System;
 using System.Collections;
 using System.Collections.Generic;
@@ -25,7 +26,7 @@ public object Convert(object value, Type targetType, object parameter, CultureIn
             if (parameter is not CollectionViewSource view_source)
                 throw new ApplicationException("ConverterParameter must be a CollectionViewSource representing the CastGroups.");
             if (value is ObservableCollection<CountByGroup> collection && view_source.Source is IList list)
-                return list.OfType<CastGroup>().Select(g => new NullableCountByGroup(collection, g)).ToList();
+                return list.OfType<CastGroup>().InOrder().Select(g => new NullableCountByGroup(collection, g)).ToList();
             return value;
         }
 

Desktop/Pages/SelectCast.xaml.cs

@@ -228,6 +228,7 @@ private async void selectCastButton_Click(object sender, RoutedEventArgs e)
             };
             if (dialog.ShowDialog() != true)
                 return;
+            ClearMainPanel();
             using var processing = new LoadingOverlay(this).AsSegment(nameof(selectCastButton_Click), "Processing...");
             using (processing.Segment(nameof(ISelectionEngine.SelectCastGroups), "Selecting applicants"))
             {
@@ -527,6 +528,12 @@ private static void RemoveFromSameCastSet(SameCastSet set, Applicant[] applicant
             }
         }
 
+        private void ClearMainPanel()
+        {
+            selectionList.SelectedItem = null;
+            RefreshMainPanel();
+        }
+
         private void selectionList_SelectionChanged(object sender, SelectionChangedEventArgs e)
         {
             if (suitabilityComparer != null)
@@ -749,7 +756,7 @@ private void SortBySuitability(CollectionViewSource collection)
             if (collection.View is ListCollectionView view)
                 view.CustomSort = suitabilityComparer;
         }
-
+                
         private void GroupByCastGroupCheckbox_Changed(object sender, RoutedEventArgs e)
         {
             if (selectionList?.SelectedItem != null)
@@ -778,13 +785,12 @@ public int Compare(object? x, object? y)
             // sort by cast group (if grouping)
             if (GroupByCastGroup)
             {
-                if (a1.CastGroup is not CastGroup cg1)
-                    return int.MinValue;
-                if (a2.CastGroup is not CastGroup cg2)
-                    return int.MaxValue;
-                if (cg1.Order > cg2.Order)
+                // Note: if CastGroup.Order somehow gets set to int.MinValue, it will be considered the same ordering as no cast group
+                var cg1 = a1.CastGroup?.Order ?? int.MinValue;
+                var cg2 = a2.CastGroup?.Order ?? int.MinValue;
+                if (cg1 > cg2)
                     return 1;
-                if (cg1.Order < cg2.Order)
+                if (cg1 < cg2)
                     return -1;
             }
             // sort by suitability

Desktop/ViewModels/ApplicantForSelection.cs

@@ -23,7 +23,7 @@ public class ApplicantForSelection : ISelectableApplicant, INotifyPropertyChange
         public bool IsSelected
         {
             get => true; // so that colour images are shown
-            set => throw new InvalidOperationException();
+            set { }
         }
 
         public string FirstName => Applicant.FirstName;