Skip to content

Commit

Permalink
refactor: introduce secondary entry points (start with json ld) (#4)
Browse files Browse the repository at this point in the history
* refactor: json ld as secondary entrypoint

* refactor: remove index.ts from json-ld (not needed 4 now)

* refactor: add common entry point
davidlj95 authored Nov 22, 2023

Verified

This commit was signed with the committer’s verified signature.
mrgrain Momo Kornher
1 parent eb5198e commit 4d0131d
Showing 17 changed files with 41 additions and 19 deletions.
2 changes: 1 addition & 1 deletion angular.json
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
"ngx-metadata": {
"projectType": "library",
"root": "projects/ngx-metadata",
"sourceRoot": "projects/ngx-metadata/src",
"sourceRoot": "projects/ngx-metadata",
"prefix": "lib",
"architect": {
"build": {
1 change: 1 addition & 0 deletions projects/ngx-metadata/common/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './public-api'
7 changes: 7 additions & 0 deletions projects/ngx-metadata/common/ng-package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"$schema": "../../../node_modules/ng-packagr/ng-package.schema.json",
"dest": "../../dist/ngx-metadata",
"lib": {
"entryFile": "public-api.ts"
}
}
1 change: 1 addition & 0 deletions projects/ngx-metadata/common/public-api.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { MetadataApplier as _MetadataApplier } from './src/metadata-applier'
3 changes: 3 additions & 0 deletions projects/ngx-metadata/common/src/metadata-applier.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export interface MetadataApplier<M> {
apply(metadata: M): void
}
1 change: 1 addition & 0 deletions projects/ngx-metadata/json-ld/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './public-api'
7 changes: 7 additions & 0 deletions projects/ngx-metadata/json-ld/ng-package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"$schema": "../../../node_modules/ng-packagr/ng-package.schema.json",
"dest": "../../dist/ngx-metadata",
"lib": {
"entryFile": "public-api.ts"
}
}
2 changes: 2 additions & 0 deletions projects/ngx-metadata/json-ld/public-api.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export * from './src/json-ld.module'
export * from './src/json-ld.service'
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { Inject, Injectable } from '@angular/core'
import { DOCUMENT } from '@angular/common'
import { MetadataApplier } from '../common/metadata-applier'
import { _MetadataApplier } from 'ngx-metadata/common'

@Injectable()
export class JsonLdService implements MetadataApplier<object> {
export class JsonLdService implements _MetadataApplier<object> {
private readonly SCRIPT_TYPE = 'application/ld+json'

constructor(@Inject(DOCUMENT) private readonly document: Document) {}
2 changes: 1 addition & 1 deletion projects/ngx-metadata/ng-package.json
Original file line number Diff line number Diff line change
@@ -2,6 +2,6 @@
"$schema": "../../node_modules/ng-packagr/ng-package.schema.json",
"dest": "../../dist/ngx-metadata",
"lib": {
"entryFile": "src/public-api.ts"
"entryFile": "public-api.ts"
}
}
11 changes: 11 additions & 0 deletions projects/ngx-metadata/public-api.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
/*
* Public API Surface of ngx-metadata
*/

export { NgxMetadataModule } from './src/lib/ngx-metadata.module'
export * from './src/lib/common'
export * from './src/lib/general-metadata'
export * from './src/lib/open-graph'
export * from './src/lib/open-graph-profile'
export * from './src/lib/routing'
export * from './src/lib/twitter-card'
2 changes: 0 additions & 2 deletions projects/ngx-metadata/src/lib/json-ld/index.ts

This file was deleted.

12 changes: 0 additions & 12 deletions projects/ngx-metadata/src/public-api.ts

This file was deleted.

5 changes: 4 additions & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
@@ -11,7 +11,10 @@
"noFallthroughCasesInSwitch": true,
"esModuleInterop": true,
"paths": {
"ngx-metadata": ["./dist/ngx-metadata"]
// 👇 Changed to add secondary entry points
// "ngx-metadata": ["./dist/ngx-metadata"],
"ngx-metadata/*": ["./projects/ngx-metadata/*"],
"ngx-metadata": ["./projects/ngx-metadata"]
},
"sourceMap": true,
"declaration": false,

0 comments on commit 4d0131d

Please sign in to comment.