test: add and use util to inject one metadata manager #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @davidlj95 and the rest of your teammates on |
davidlj95
force-pushed
the
stacked/test-add-and-use-util-to-inject-one-metadata-manager
branch
from
e1e8e71 to
67254c6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #893 +/- ##
=======================================
Coverage 99.46% 99.46%
=======================================
Files 79 79
Lines 372 372
Branches 73 73
=======================================
Hits 370 370
Partials 2 2 ☔ View full report in Codecov by Sentry. |
📦 Bundle size (Angular v17)Git ref:
|
📦 Bundle size (Angular v18)Git ref:
|
📦 Bundle size (Angular v16)Git ref:
|
📦 Bundle size (Angular v15)Git ref:
|
davidlj95
force-pushed
the
stacked/test-add-and-use-util-to-inject-one-metadata-manager
branch
from
67254c6 to
d6723b8
Compare
davidlj95
deleted the
stacked/test-add-and-use-util-to-inject-one-metadata-manager
branch
|
🎉 This PR is included in version 1.0.0-beta.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue or need
A trick is used right now for existing metadata manager tests in order to unit test the metadata manager (its setter, actually).
This is done because metadata managers are provided as part of a
multiprovider for theNgxMetaMetadataManagertoken / abstract class.So can't inject one specifically.
The trick has been to export the setter factory (that comes with dependencies as arguments). Then, when unit testing, manually inject the needed dependencies.
This is not ideal because it doesn't reflect real use (where automatic injection is done).
And now is an impediment for a subsequent refactor removing the
depsusage by calls toinjectin the factory. Then, a way is needed to unit test metadata managers without manually injecting. As otherwise, an error will appear about usinginjectin a non-injection context.Proposed changes
Introduce
injectOneMetadataManagerutil for tests. Which will inject the only metadata manager existing. Or throw otherwise.injectMetadataManagershas been internally exported in order to use it for that util too.Then, use that util around to avoid the trick.
Other changes: unite
undefined/nulltest cases in a describe + for loop.Quick reminders