Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: inline setter factories #937

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

davidlj95
Copy link
Owner

Issue or need

After #893, there's no need to declare a metadata manager's setter factory apart

Proposed changes

Inline all metadata manager setter factories

Quick reminders

  • 🤝 I will follow Code of Conduct
  • No existing pull request already does almost same changes
  • 👁️ Contributing docs are something I've taken a look at
  • 📝 Commit messages convention has been followed
  • 💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
  • 🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
  • ⚙️ API Report has been updated if API surface is altered.

@davidlj95 davidlj95 enabled auto-merge (squash) October 13, 2024 11:46
Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (ab420ab) to head (0ca0cb0).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
- Coverage   98.14%   98.11%   -0.03%     
==========================================
  Files          83       83              
  Lines         377      372       -5     
  Branches       70       70              
==========================================
- Hits          370      365       -5     
  Misses          3        3              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidlj95 davidlj95 merged commit 479fe2b into main Oct 13, 2024
34 checks passed
@davidlj95 davidlj95 deleted the stacked/refactor-inline-setter-factories branch October 13, 2024 11:51
Copy link

📦 Bundle size (Angular v16)

Git ref: 0ca0cb0ebd4cae7ba11113f4c7eaae7cd8c74179

Module file Size Base size Difference
ngx-meta-core.mjs 3386 bytes (3.4KiB) 3386 bytes (3.4KiB) No change
ngx-meta-json-ld.mjs 370 bytes (370B) 370 bytes (370B) No change
ngx-meta-open-graph.mjs 1284 bytes (1.3KiB) 1284 bytes (1.3KiB) No change
ngx-meta-routing.mjs 572 bytes (572B) 572 bytes (572B) No change
ngx-meta-standard.mjs 1054 bytes (1.1KiB) 1054 bytes (1.1KiB) No change
ngx-meta-twitter-card.mjs 679 bytes (679B) 679 bytes (679B) No change
Total 7345 bytes (7.2KiB) 7345 bytes (7.2KiB) No change

Copy link

📦 Bundle size (Angular v15)

Git ref: 0ca0cb0ebd4cae7ba11113f4c7eaae7cd8c74179

Module file Size Base size Difference
ngx-meta-core.mjs 3346 bytes (3.3KiB) 3346 bytes (3.3KiB) No change
ngx-meta-json-ld.mjs 355 bytes (355B) 355 bytes (355B) No change
ngx-meta-open-graph.mjs 1254 bytes (1.3KiB) 1254 bytes (1.3KiB) No change
ngx-meta-routing.mjs 557 bytes (557B) 557 bytes (557B) No change
ngx-meta-standard.mjs 1039 bytes (1.1KiB) 1039 bytes (1.1KiB) No change
ngx-meta-twitter-card.mjs 664 bytes (664B) 664 bytes (664B) No change
Total 7215 bytes (7.1KiB) 7215 bytes (7.1KiB) No change

Copy link

📦 Bundle size (Angular v18)

Git ref: 0ca0cb0ebd4cae7ba11113f4c7eaae7cd8c74179

Module file Size Base size Difference
ngx-meta-core.mjs 2978 bytes (3.0KiB) 2978 bytes (3.0KiB) No change
ngx-meta-json-ld.mjs 220 bytes (220B) 226 bytes (226B) -2.65%: -6 bytes (-6B)
ngx-meta-open-graph.mjs 985 bytes (985B) 997 bytes (997B) -1.20%: -12 bytes (-12B)
ngx-meta-routing.mjs 394 bytes (394B) 394 bytes (394B) No change
ngx-meta-standard.mjs 907 bytes (907B) 949 bytes (949B) -4.42%: -42 bytes (-42B)
ngx-meta-twitter-card.mjs 534 bytes (534B) 540 bytes (540B) -1.11%: -6 bytes (-6B)
Total 6018 bytes (5.9KiB) 6084 bytes (6.0KiB) -1.08%: -66 bytes (-66B)

Copy link

📦 Bundle size (Angular v17)

Git ref: 0ca0cb0ebd4cae7ba11113f4c7eaae7cd8c74179

Module file Size Base size Difference
ngx-meta-core.mjs 2978 bytes (3.0KiB) 2978 bytes (3.0KiB) No change
ngx-meta-json-ld.mjs 220 bytes (220B) 226 bytes (226B) -2.65%: -6 bytes (-6B)
ngx-meta-open-graph.mjs 985 bytes (985B) 997 bytes (997B) -1.20%: -12 bytes (-12B)
ngx-meta-routing.mjs 394 bytes (394B) 394 bytes (394B) No change
ngx-meta-standard.mjs 907 bytes (907B) 949 bytes (949B) -4.42%: -42 bytes (-42B)
ngx-meta-twitter-card.mjs 534 bytes (534B) 540 bytes (540B) -1.11%: -6 bytes (-6B)
Total 6018 bytes (5.9KiB) 6084 bytes (6.0KiB) -1.08%: -66 bytes (-66B)

Copy link

🎉 This PR is included in version 1.0.0-beta.20 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant