-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: inline setter factories #937
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @davidlj95 and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #937 +/- ##
==========================================
- Coverage 98.14% 98.11% -0.03%
==========================================
Files 83 83
Lines 377 372 -5
Branches 70 70
==========================================
- Hits 370 365 -5
Misses 3 3
Partials 4 4 ☔ View full report in Codecov by Sentry. |
📦 Bundle size (Angular v16)Git ref:
|
📦 Bundle size (Angular v15)Git ref:
|
📦 Bundle size (Angular v18)Git ref:
|
📦 Bundle size (Angular v17)Git ref:
|
🎉 This PR is included in version 1.0.0-beta.20 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Issue or need
After #893, there's no need to declare a metadata manager's setter factory apart
Proposed changes
Inline all metadata manager setter factories
Quick reminders