-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: refactor ng-add test to do same for standalone and module #973
test: refactor ng-add test to do same for standalone and module #973
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @davidlj95 and the rest of your teammates on Graphite |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #973 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 86 86
Lines 365 365
Branches 52 52
=========================================
Hits 365 365 ☔ View full report in Codecov by Sentry. |
📦 Bundle size (Angular v18)Git ref:
|
📦 Bundle size (Angular v16)Git ref:
|
📦 Bundle size (Angular v15)Git ref:
|
📦 Bundle size (Angular v17)Git ref:
|
🎉 This PR is included in version 1.0.0-beta.27 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Issue or need
Was about to add some features to the
ng-add
schematic, but when adding tests for those, noticed that tests would need to be duplicated: one for standalone, one for module-based.Proposed changes
Refactor
ng-add
tests so that same is tested for standalone and module-based appsQuick reminders