Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor ng-add test to do same for standalone and module #973

Merged
merged 1 commit into from
Oct 21, 2024
Merged

test: refactor ng-add test to do same for standalone and module #973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 29 additions & 43 deletions projects/ngx-meta/schematics/ng-add/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,53 +24,34 @@ describe('ng-add schematic', () => {
join(__dirname, '..', 'collection.json'),
)
})

describe('when the app is standalone', () => {
beforeEach(async () => {
appTree = await createTestApp(runner, {
name: defaultOptions.project,
standalone: true, // to be explicit, but it's the default now
;([true, false] as const).forEach((standalone) => {
const appKind = standalone ? 'standalone' : 'module-based'
describe(`when the app is ${appKind}`, () => {
beforeEach(async () => {
appTree = await createTestApp(runner, {
name: defaultOptions.project,
standalone,
})
})
})

it('should add core provider to app config', async () => {
const tree = await runner.runSchematic<NgAddSchema>(
SCHEMATIC_NAME,
defaultOptions,
appTree,
)
const appConfig = getFileContent(tree, '/src/app/app.config.ts')
expect(appConfig).toContain(
`import { provideNgxMetaCore } from '${LIB_NAME}/core`,
)
expect(stripWhitespace(appConfig)).toMatch(
/providers:\[.*provideNgxMetaCore\(\).*]/,
)
})
})

describe('when the app is module-based', () => {
beforeEach(async () => {
appTree = await createTestApp(runner, {
name: defaultOptions.project,
standalone: false,
it('should add core provider', async () => {
const tree = await runner.runSchematic<NgAddSchema>(
SCHEMATIC_NAME,
defaultOptions,
appTree,
)
const appConfigOrAppModule = getAppConfigOrAppModuleContents(
tree,
standalone,
)
expect(appConfigOrAppModule).toContain(
`import { provideNgxMetaCore } from '${LIB_NAME}/core`,
)
expect(stripWhitespace(appConfigOrAppModule)).toMatch(
/providers:\[.*provideNgxMetaCore\(\).*]/,
)
})
})

it('should add core provider to app module', async () => {
const tree = await runner.runSchematic<NgAddSchema>(
SCHEMATIC_NAME,
defaultOptions,
appTree,
)
const appModule = getFileContent(tree, '/src/app/app.module.ts')
expect(appModule).toContain(
`import { provideNgxMetaCore } from '${LIB_NAME}/core`,
)
expect(stripWhitespace(appModule)).toMatch(
/providers:\[.*provideNgxMetaCore\(\).*]/,
)
})
})
})

Expand All @@ -91,6 +72,11 @@ const createTestApp = async (
)
}

const getAppConfigOrAppModuleContents = (tree: Tree, standalone: boolean) =>
standalone
? getFileContent(tree, '/src/app/app.config.ts')
: getFileContent(tree, '/src/app/app.module.ts')

// https://github.com/angular/components/blob/18.2.8/src/cdk/schematics/testing/file-content.ts
const getFileContent = (tree: Tree, filePath: string): string => {
const contentBuffer = tree.read(filePath)
Expand Down