Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unneeded entries in CI's Makefile #1034

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions .ci/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,31 +4,13 @@
build:
cd .. && pnpm run build

tsc:
cd .. && pnpm run ngx-meta:tsc

install:
# Despite it's enabled by default on CI. This allows to mock CI locally
# https://pnpm.io/cli/install#--frozen-lockfile
pnpm install --frozen-lockfile

lint-gh-actions:
ationlint

unit-test-libs:
pnpm run test:unit:libs:coverage \
--browsers=ChromeHeadless \
--no-progress \
--reporters progress

unit-test-schematics:
cd .. && pnpm run test:unit:schematics:coverage

release:
cd .. && pnpm semantic-release

api-extractor:
cd .. && pnpm run ngx-meta:api-extractor

api-documenter:
cd .. && pnpm run ngx-meta:api-documenter
4 changes: 2 additions & 2 deletions .github/workflows/reusable-api-extractor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
- name: Run API Extractor in production mode
run: cd .ci && make api-extractor
run: pnpm run ngx-meta:api-extractor
- name: Run API Documenter
run: cd .ci && make api-documenter
run: pnpm run ngx-meta:api-documenter
- name: Upload API Documenter generated Markdown docs
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/reusable-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
path: .angular/cache
key: angular-cache
- name: Build libraries
run: cd .ci && make build
run: pnpm run build
- name: Upload distribution files
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4
with:
Expand All @@ -53,7 +53,7 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
- name: Run tsc
run: cd .ci && make tsc
run: pnpm run ngx-meta:tsc
- name: Upload compiled JS files
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.npm-token }}
run: cd .ci && make release
run: pnpm semantic-release
- name: Create Pull Request
id: cpr
uses: peter-evans/create-pull-request@5e914681df9dc83aa4e4905692ca88beb2f9e91f # v7
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
- name: Run unit tests
run: cd .ci && make unit-test-schematics
run: pnpm run test:unit:schematics:coverage
- name: Upload coverage report
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4
if: failure() || success()
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,9 @@ If adding a whole metadata module, add it to the built-in modules section too.

### CI/CD jobs

To easily reproduce locally CI/CD jobs, most commands run by CI/CD are stored in [`.ci/Makefile` file](.ci/Makefile).
To easily reproduce locally CI/CD jobs, commands run by CI/CD which are different from commands ran locally are stored in [`.ci/Makefile` file](.ci/Makefile).

For instance, you can run `make build` (or just `make` in this case) to ensure the command used to build is the same one the CI/CD job will use.
For instance, you can run `make install` to run the same command used in CI/CD for installing.

### Release and versioning

Expand Down