-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(standard): add theme color meta #772
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @davidlj95 and the rest of your teammates on Graphite |
2c2d90a
to
9d869c1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #772 +/- ##
==========================================
+ Coverage 97.31% 97.42% +0.11%
==========================================
Files 74 75 +1
Lines 335 350 +15
Branches 58 61 +3
==========================================
+ Hits 326 341 +15
Partials 9 9 ☔ View full report in Codecov by Sentry. |
9d869c1
to
917dfd9
Compare
917dfd9
to
6f99454
Compare
📦 Bundle size (Angular v15)Git ref:
|
📦 Bundle size (Angular v16)Git ref:
|
📦 Bundle size (Angular v18)Git ref:
|
📦 Bundle size (Angular v17)Git ref:
|
82e62fd
to
1dfa28b
Compare
🎉 This PR is included in version 1.0.0-beta.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Issue or need
Fixes #771
Proposed changes
Adds a new metadata provider for
standard
module to manage<meta name="theme-color">
This one is a bit tricky as:
media
attribute can be specified. To specify a theme color based on a CSS media query context. Like one for light mode and another for dark mode.media
attribute to specify one for light mode and one for dark mode.API
The introduced metadata manager allows for most cases:
undefined
ornull
, as usualmedia
CSS query: provide an array with objects specifying media query and colormedia
CSS query: provide an array with objects specifying (or not) media query and colorThis should be cover all possible cases.
To think about
RenameYup, much more expressivecontent
tocolor
?Simplify API possible values by dropping the. Not much code would be reduced, given we need to have that branch of code anyway forstring
value. If you want just 1 colour, specify an array with only 1 object with that color. This reduces a bit of code. A bit inconvenient if just 1 colour to set thoughnull
|undefined
values. Leaving it there for nowPending
Add to features listQuick reminders