Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: EXDEV: cross-device link not permitted #260

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

Minhir
Copy link
Contributor

@Minhir Minhir commented Jul 14, 2022

It's impossible to use 0x with volumes mounted on different file systems.

Error: 
EXDEV: cross-device link not permitted, rename '/dir1/isolate-0x2f2a329ae330-418-418-v8.log' -> '/dir2/isolate-0x2f2a329ae330-418-418-v8.log'

The reason of such behavior is fs.rename. So I added fs-extra and use move instead.

P.S. Also, there was infinity loop in renameSafe. This is because of i++ 🙈

Probably fix #241

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 9c60bfc into davidmarkclements:master Jul 14, 2022
@Minhir Minhir deleted the fix-move branch July 14, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not generate files in docker
2 participants