Support specifying classpath for additional velocity tool classes

[crtlib]

Hi. Needed this for instantiating some custom non-published velocity tool classes. Would be great to have it released soon 🙏

[davidmc24]

Thanks for the PR. I'm open to this change, but don't want to break compatibility for it. If you resolve that issue with test coverage to prove compatibility, I should be able to merge and release relatively soon afterward.

[crtlib]

Thanks, David. Indeed, my change broke the supports configuring velocity tool classes in OptionsFunctionalSpec. I just force-pushed a change, so that we now specify the parent classloader in our custom one. That fixed the tests. Does it mean that the current tests already cover the needed compatibility? If not, can you please elaborate on what kind of test you have in mind? Thank you!

[davidmc24]

Yes, I'd thought that there was coverage for additional velocity tools. I try pretty hard not to add features without test coverage. If it failed before and passes now, that's probably good enough. We'll just need test coverage for the new case, where the classpath is configured (if you haven't added that already)

[crtlib]

Hi, David. Looks like I've managed to deliver a test for the new property 😅 Please take a look 🙏

[davidmc24]

Looks good, with minor tweaks that I'll take care of post-merge. I'll merge now; assuming that the CI run looks clean I'll pursue a release in the next day or two.

[crtlib]

@davidmc24 Thanks a lot 🙏

[davidmc24]

@crtlib Looks like the new test (and maybe functionality) isn't Windows compatible. Mind trying for a fix?

https://github.com/davidmc24/gradle-avro-plugin/actions/runs/4055083756/jobs/6977738565

[crtlib]

@davidmc24 Sure, David. I'll give a try.

[crtlib]

@davidmc24 Here it is: crtlib@e778f21. Should I create a PR or you'll just cherry-pick?

[davidmc24]

PR if possible, please

[davidmc24]

@crtlib Release underway. Once https://github.com/davidmc24/gradle-avro-plugin/actions/runs/4104821988 completes, it should be published to Maven Central as version 1.6.0.

[davidmc24]

Released

[crtlib]

@davidmc24 Thank you so much 🙏