Folder posts #1027

davidmerfield · 2025-10-20T11:42:18Z

Some kind of markup structure that makes it possible to build a slideshow? e.g. <section class="multi-file-post"><section data-source="{{path}}">...
This should work recursively for subfolders? up to a limit of say 50 files? if there are too many files, don't build the post at all. sort all the paths alphabetically before concatentating
Ignored files (e.g. _1.jpg) are still added to multi file posts
Do we think about injecting a title for posts without one? maybe with a class so it could easily be hidden in CSS?
Resolve bug with folder '[Blog]+'
- add test for this
Dashboard file viewer needs to handle multi-file posts properly
- add test for this
- change the icon for the folder to include the checkmark

https://chatgpt.com/codex/tasks/task_e_68f618afe9188329b32153d161c70a5b

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2025-10-20T11:45:36Z

app/sync/update/index.js

        } else if (stat && stat.isDirectory()) {
          maybeEnableInjectTitle(blog, path, function () {
-            // there is nothing else to do for directories
-            done();
+            var multiInfo = build.findMultiFolder(path);
+
+            if (multiInfo) {
+              var targetPath = multiInfo.folderPath;
+
+              log(path, "Saving multi-folder in database");
+
+              set(blog, targetPath, function (err) {
+                if (err) {
+                  log(targetPath, "Error saving multi-folder in database", err);
+                } else {
+                  log(targetPath, "Saving multi-folder in database succeeded");
+                }
+                done(err);


Drop multi-folder entry when directory is removed

This branch builds aggregated content when a + directory exists, but the ENOENT branch above still drops only the directory path (/album+). The published entry for that folder lives at the plus-stripped entryPath, so deleting the folder leaves /album and its preview in the database because nothing ever removes it or rebuilds dependents. Consider also dropping multiInfo.entryPath when the folder disappears so that multi-folder deletions clean up their synthesized entry.

Useful? React with 👍 / 👎.

davidmerfield · 2025-10-20T12:53:48Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2025-10-20T12:56:59Z

app/sync/update/index.js

      fs.stat(localPath(blog.id, path), function (err, stat) {
        if (err && err.code === "ENOENT") {
-          log(path, "Dropping from database");
-          drop(blog.id, path, function (err) {
-            if (err) {
-              log(path, "Error dropping from database", err);
-            } else {
-              log(path, "Dropping from database succeeded");
-            }
-            done(err);
-          });
+          var dropTargets = [path];
+          var multiInfo = build.findMultiFolder(path);
+
+          if (
+            multiInfo &&
+            multiInfo.folderPath === path &&
+            multiInfo.entryPath &&
+            dropTargets.indexOf(multiInfo.entryPath) === -1
+          ) {
+            dropTargets.push(multiInfo.entryPath);
+          }
+
+          var dropError = null;
+
+          (function nextDrop(index) {
+            if (index >= dropTargets.length) return done(dropError);
+
+            var target = dropTargets[index];
+            log(target, "Dropping from database");
+            drop(blog.id, target, function (err) {
+              if (err) {
+                log(target, "Error dropping from database", err);
+                if (!dropError) dropError = err;
+              } else {
+                log(target, "Dropping from database succeeded");
+              }
+
+              nextDrop(index + 1);
+            });
+          })(0);


Rebuild multi-folder entry when a child file is removed

The delete branch only drops path and, if the removed path is the +/ folder, its aggregate. When a single file inside a multi-folder is deleted (e.g. /album+/two.md), this branch does not rebuild or drop /album, so the published entry continues to contain content from the deleted file until some other change touches the folder. Nothing elsewhere schedules a rebuild for /album on child deletion, so multi-folder posts can display stale content after a source file is removed. Consider triggering a rebuild of the aggregated entry whenever any path under the multi-folder disappears.

Useful? React with 👍 / 👎.

davidmerfield · 2025-10-20T13:08:26Z

@codex review

chatgpt-codex-connector · 2025-10-20T13:16:51Z

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

davidmerfield · 2025-10-30T15:47:55Z

@codex review

chatgpt-codex-connector · 2025-10-30T15:53:27Z

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

davidmerfield · 2025-10-30T15:57:49Z

@codex files which should be ignored (e.g. _1.jpg or _images/1.jpg) are still added to multi file posts. Please revise to prevent these files from inclusion in these posts

chatgpt-codex-connector · 2025-10-30T16:01:38Z

Summary

Added ignore checks when gathering multi-folder source files so hidden, underscore, and public assets are skipped during aggregation. app/build/multiple.jsL132-L239
Added a regression test confirming that hidden files within multi-folder directories are omitted from the generated multi-file post. app/sync/tests/multi-folders.jsL42-L66

Testing

⚠️ npm test -- app/sync/tests/multi-folders.js (fails: scripts/tests/test.env missing in container)

View task →

davidmerfield · 2025-10-30T16:06:41Z

@codex This should work recursively for subfolders? up to a limit of say 50 files? if there are too many files, don't build the post at all. sort all the paths alphabetically before concatenating, e.g. 1.jpg, 2/a.jpg, 2/b.jpg, 3.jpg etc. implement please

chatgpt-codex-connector · 2025-10-30T16:10:56Z

Summary

Enforced a recursive 50-file cap when collecting multi-folder sources, aborting aggregation with a dedicated error once the limit is exceeded. app/build/multiple.jsL11-L202
Ensured multi-folder builds that exceed the cap drop the synthesized entry so oversized folders don’t leave stale posts behind. app/sync/update/set.jsL61-L70
Added sync coverage for nested alphabetical ordering and the over-limit guard on multi-folder aggregation. app/sync/tests/multi-folders.jsL42-L129

Testing

⚠️ npm test -- app/sync/tests/multi-folders.js (fails: ./scripts/tests/test.env does not exist in the tests directory)

View task →

davidmerfield · 2025-10-30T16:35:01Z

@codex Can we inject a title based on the folder name into the post HTML when a title tag doesn't exist in the post html? Add a classname, e.g. multi-file-title to the h1 so it can easily be hidden if so desired

chatgpt-codex-connector · 2025-10-30T16:37:42Z

Summary

Injected a derived folder-based <h1 class="multi-file-title"> heading into multi-file posts whenever no existing heading is present, including safe escaping and titlecase handling for folder names. app/build/multiple.jsL10-L358
Added a regression test confirming that heading injection occurs for multi-folder posts lacking their own titles. app/build/tests/multiple.jsL75-L91

Testing

⚠️ npm test -- app/build/tests/multiple.js (fails: ./scripts/tests/test.env does not exist in the tests directory.)

View task →

davidmerfield · 2025-10-30T19:47:18Z

@codex review

chatgpt-codex-connector · 2025-10-30T19:54:02Z

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Add multi-folder aggregation support

1ccb27e

davidmerfield added the codex label Oct 20, 2025 — with ChatGPT Codex Connector

chatgpt-codex-connector bot reviewed Oct 20, 2025

View reviewed changes

davidmerfield added 3 commits October 20, 2025 14:01

Drop aggregated entry when multi-folder is removed

25d1478

Fix expectations for multi-folder tests

8db2525

Fix multi-folder aggregation test expectations

305a358

chatgpt-codex-connector bot reviewed Oct 20, 2025

View reviewed changes

davidmerfield added 2 commits October 20, 2025 15:07

Document folder posts for plus directories

536dcdf

Rebuild multi-folder entry when children are removed

2c0bd04

Wrap multi-file posts in structured sections

8490ee1

davidmerfield added 2 commits October 20, 2025 15:21

Add audit script for existing plus folders

7dd9b76

Handle folder posts in dashboard file viewer

65d7c0c

davidmerfield changed the title ~~Add multi-folder aggregation support~~ Multi-file posts Oct 21, 2025

davidmerfield changed the title ~~Multi-file posts~~ Folder posts Oct 21, 2025

davidmerfield added 2 commits October 30, 2025 16:23

Merge

508621a

Revise test

ce8c378

Ignore ignorable files

6c21bb5

Recurse

1fc299c

Inject title

c1cd903

Updates multi-folder post tests

ca15e87

Folder posts #1027

Are you sure you want to change the base?

Folder posts #1027

Uh oh!

Conversation

davidmerfield commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

davidmerfield commented Oct 20, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

davidmerfield commented Oct 20, 2025

Uh oh!

chatgpt-codex-connector bot commented Oct 20, 2025

Uh oh!

davidmerfield commented Oct 30, 2025

Uh oh!

chatgpt-codex-connector bot commented Oct 30, 2025

Uh oh!

davidmerfield commented Oct 30, 2025

Uh oh!

chatgpt-codex-connector bot commented Oct 30, 2025

Uh oh!

davidmerfield commented Oct 30, 2025

Uh oh!

chatgpt-codex-connector bot commented Oct 30, 2025

Uh oh!

davidmerfield commented Oct 30, 2025

Uh oh!

chatgpt-codex-connector bot commented Oct 30, 2025

Uh oh!

davidmerfield commented Oct 30, 2025

Uh oh!

chatgpt-codex-connector bot commented Oct 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

davidmerfield commented Oct 20, 2025 •

edited

Loading