Makes minor refactors on Internet.domain_name method (faker-ruby#1847)

* Makes minor refactors on Internet.domain_name method

* Fixes block-code style (rubocop complaints)

* Fixes rubocop offense on method call

lib/faker/default/internet.rb

@@ -141,21 +141,19 @@ def domain_name(legacy_subdomain = NOT_GIVEN, subdomain: false, domain: nil)
  end
 
  with_locale(:en) do
- domain_elements = []
-
  if domain
- domain.split('.').each do |domain_part|
- domain_elements << Char.prepare(domain_part)
- end
- domain_elements << domain_suffix if domain_elements.length < 2
- domain_elements.unshift(Char.prepare(domain_word)) if subdomain && domain_elements.length < 3
+ domain
+ .split('.')
+ .map { |domain_part| Char.prepare(domain_part) }
+ .tap do |domain_elements|
+ domain_elements << domain_suffix if domain_elements.length < 2
+ domain_elements.unshift(Char.prepare(domain_word)) if subdomain && domain_elements.length < 3
+ end.join('.')
  else
- domain_elements << domain_word
- domain_elements << domain_suffix
- domain_elements.unshift(Char.prepare(domain_word)) if subdomain
+ [domain_word, domain_suffix].tap do |domain_elements|
+  domain_elements.unshift(Char.prepare(domain_word)) if subdomain
+ end.join('.')
  end
-
- domain_elements.join('.')
  end
  end
 

test/faker/default/test_faker_internet.rb

@@ -162,7 +162,7 @@ def test_domain_name_with_subdomain_and_with_domain_option_given
  assert @tester.domain_name(subdomain: true, domain: 'customdomain').match(/customdomain\.\w+/)
  end
 
- def test_domain_name_with_subdomain_and_with_domain_option_given_with_domain_suffixc
+ def test_domain_name_with_subdomain_and_with_domain_option_given_with_domain_suffix
  assert @tester.domain_name(subdomain: true, domain: 'customdomain.customdomainsuffix').match(/customdomain\.customdomainsuffix/)
  end