Fixed missing imports. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed error with teleop re gain vector length
davidorchansky
requested changes
Aug 3, 2023
uuv_assistants/src/message_to_tf.cpp
Outdated
| out = Vector3(msgIn.x, msgIn.y, msgIn.z); | ||
| } | ||
| } | ||
| // namespace tf2 |
There was a problem hiding this comment.
Check if this section is needed or if it can be removed
There was a problem hiding this comment.
The fromMsg function causes a compilation error. Ros humble defines the same function in /opt/ros/humble/include/tf2_geometry_msgs/tf2_geometry_msgs/tf2_geometry_msgs.hpp.
From this, I believe it is correct to remove it, as the functionality is not lost, and keeping it in fact causes errors. I shall delete that function
| @@ -26,7 +26,6 @@ Underwater environment with the ODE physics engine configured for vehicles using | |||
| <arg name="debug" value="false"/> | |||
| <arg name="verbose" value="true"/> | |||
| <!-- TODO Remove force_system in foxy, as it will be loaded by default --> | |||
There was a problem hiding this comment.
I will remove the corresponding comment from the other launch files as well
| <launch> | ||
| <arg name="gui" default="true"/> | ||
| <arg name="paused" default="false"/> | ||
| <arg name="debug" default="false"/> |
There was a problem hiding this comment.
Check how this could be reinstated
| @@ -20,11 +20,10 @@ | |||
| <arg name="use_sim_time" value="$(var use_sim_time)"/> | |||
| <arg name="gui" value="$(var gui)"/> | |||
| <arg name="headless" value="false"/> | |||
| <arg name="debug" value="$(var debug)"/> | |||
| <arg name="debug" value="false"/> | |||
There was a problem hiding this comment.
Need to revert this change
davidorchansky
approved these changes
Aug 3, 2023
davidorchansky
changed the base branch from
galactic-development
to
humble-development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed error with teleop re gain vector length by creating custom function to convert list of str to int.
Also removed imports and functions which were causing issues