Skip to content

Commit

Permalink
Fix buffer issue with S3D USB printing
Browse files Browse the repository at this point in the history
  • Loading branch information
@davidramiro
davidramiro committed Feb 11, 2019
1 parent 28e86b9 commit bfe39a3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Marlin/Marlin_main.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8553,7 +8553,7 @@ inline void gcode_M109() {
#endif

// flush the serial buffer after heating to prevent lockup by m105
flush_and_request_resend();
SERIAL_FLUSH();

}

Expand Down Expand Up @@ -8708,7 +8708,7 @@ inline void gcode_M109() {
#endif

// flush the serial buffer after heating to prevent lockup by m105
flush_and_request_resend();
SERIAL_FLUSH();
}

#endif // HAS_HEATED_BED
Expand Down

4 comments on commit bfe39a3

@jkmajcen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woh! Nice! A one liner can solve this problem that has been plaguing me for years? Fingers crossed.

@davidramiro
Copy link
Owner Author

@davidramiro davidramiro commented on bfe39a3 Feb 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't get your hopes up too soon! This is just a fix for a very specific issue where Simplify3D would get caught in a loop after heating, had to do with EMERGENCY_PARSER.

What is the issue you're seeing?

@jkmajcen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When printing via USB, I'll get this sporadic pause that lasts for a couple seconds and then continues on. Could happen once, could happen multiple times, or not at all. The result is an easily visible blob on the surface. Never happens when printing from SD card. I thought it might have had something to do with the live print preview but I've had it happen with it turned off or not viewing the preview at all. Super frustrating.

@davidramiro
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushing minimum segment time to 50ms could help - already done that in f01026e but your EEPROM might still have the old value. When doing M503, what output do you get on line M205?

Please sign in to comment.