Built-in SSH #27
Merged
Built-in SSH #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can SSH places and it works. Only password auth is currently implemented. Host key verification has a bad UI too and needs to be redone. Lots of other stuff still missing or buggy.
Closed
Closed
Remove future stuff to do section - thats all in the issue tracker now.
Now that its enabled via NETPTY it already shows
It wasn't really enabled as all the algorithms were disabled or weren't being built (via crypt dll) but it was showing as available in the "show features" command.
It doesn't need to be turned on - its on by default. We only need to not turn it off.
This now all lives in feature_flags.mak so it can be applied to KUI too. Turning off debug logging now works.
And fixed display of the banner. Code is also there for keyboard interactive but it isn't currently working for some unknown reason.
To reduce chance of breaking older versions of Visual C++
ckoco3.c(11999) : warning C4172: returning address of local variable or temporary: s
This appears to fix the random disconnect problem though its a pretty massive change and *significantly* increases the complexity of the libssh interface so chances are it also introduces some exciting new subtle bugs.
Its in source control now (so we can set windows version compatibility info)
And significantly increased log spam. Seems to be pretty reliable now.
Was caused by not correctly initialising the client state.
And update the readme
And tested all the various code paths. Seems to be working properly now.
User can now specify which authentication methods to use. The gssapi, keyboard-interactive, password and pubkey options are processed though only password and pubkey authentication are currently implemented.
But it is less firmly disabled now - you can turn it on by going "set ssh v2 auth keyb" before starting your session.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reinstate the built-in SSH feature with commands like "ssh", "set ssh", and "show ssh" using libssh.
Goal is basic terminal services supporting file transfer via the kermit protocol. Forwarding (including X11) plus some other stuff like SFTP can come later.
ssh_inc() - channel read error[]=-1messages are logged