PHP 7.4 issue

[codeclinic]

There is an issue with TF at php 7.4

Trying to access array offset on value of type null in... titan-framework/lib/class-admin-page.php on line 78

So it's

$settings['parent'] = $this->settings['id'];

at function

public function createAdminPanel( $settings ) { $settings['parent'] = $this->settings['id']; return $this->owner->createAdminPanel( $settings ); }

See: gambitph#427

[goodwinpress]

I've got the solution, by the way.

In titan-framework/lib/class-admin-page.php, line 19, change

public $settings;

to

public $settings = array();

and then change at lines 77 and 83

$settings['parent'] = $this->settings['id'];

to

$settings['parent'] = $this->settings['id'] ?? null;

Hope this helps someone.

[codeclinic]

@goodwinpress If you could create pull request for this it would be a great help. Thanks.

[davidsneighbour]

Those line numbers aren't right, but I added a PR for this. Have a look and let me know if this fixes the issue.

[goodwinpress]

Yes, all correct.

[davidsneighbour]

fixed in #dc8fbcc

[davidsneighbour]

@all-contributors

add @davidsneighbour for bug,code,content,data,doc,design,ideas,infra,maintenance,projectManagement,question,review,security,test
add @codeclinic for bug,ideas,question
add @goodwinpress for bug,code

[allcontributors]

@davidsneighbour

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

[davidsneighbour]

bear with me ;)

@all-contributors add @davidsneighbour for bug,code,content,data,doc,design,ideas,infra,maintenance,projectManagement,question,review,security,test
@all-contributors add @codeclinic for bug,ideas,question
@all-contributors add @goodwinpress for bug,code

[allcontributors]

@davidsneighbour

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

[davidsneighbour]

@all-contributors please add @davidsneighbour for bug, code, content, data, doc, design, ideas, infra, maintenance, projectManagement, question, review, security and test

@all-contributors please add @codeclinic for bug, ideas and question

@all-contributors please add @goodwinpress for bug and code

[allcontributors]

@davidsneighbour

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

[davidsneighbour]

@all-contributors please add @davidsneighbour for bug, code, content, data, doc, design, ideas, infra, maintenance, projectManagement, question, review, security and test

[allcontributors]

@davidsneighbour

I've put up a pull request to add @davidsneighbour! 🎉

[davidsneighbour]

@all-contributors please add @codeclinic for bug, ideas and question

[allcontributors]

@davidsneighbour

I've put up a pull request to add @codeclinic! 🎉

[davidsneighbour]

@all-contributors please add @goodwinpress for bug and code

[allcontributors]

@davidsneighbour

I've put up a pull request to add @goodwinpress! 🎉