Fix typos & handle undefined max_reps
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkatychev
commented
Aug 10, 2024
Comment on lines
+423
to
+433
| function opt_decr(opt_num) = | ||
| is_undef(opt_num) ? undef | ||
| : opt_num - 1 ; | ||
|
|
||
| function _match_repetition(string, regex, min_reps, max_reps, pos, ignore_case=false) = | ||
| pos == undef? | ||
| undef | ||
| : pos > len(string)? | ||
| undef | ||
| : _null_coalesce( | ||
| _match_repetition(string, regex, min_reps-1, max_reps-1, | ||
| _match_parsed_rx(string, regex, pos, ignore_case=ignore_case), | ||
| _match_repetition(string, regex, opt_decr(min_reps), opt_decr(max_reps), |
There was a problem hiding this comment.
this is the code change that was done to handle #21
mkatychev
changed the title
max_reps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max_repsis undefined in_match_repetition