Skip to content

Commit

Permalink
Merge pull request UpHabit#11 from UpHabit/fix/compile-as-test
Browse files Browse the repository at this point in the history
fix(ci): make sure we can compile as a test
  • Loading branch information
GabrielCastro authored Aug 2, 2019
2 parents f1a5318 + 542429b commit d3d0300
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion lib/success.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ function getTickets(config: PluginConfig, context: GenerateNotesContext): string
const patterns = config.ticketPrefixes!
.map(prefix => new RegExp(`\\b${escapeRegExp(prefix)}-(\\d+)\\b`, 'giu'));

const tickets = new Set();
const tickets = new Set<string>();
for (const commit of context.commits) {
for (const pattern of patterns) {
const matches = pattern.exec(commit.message);
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
"private": false,
"scripts": {
"prepublishOnly": "mkdir -p dist && rm -rf dist && tsc -p .",
"test": "tslint -p . && true \n#\n# No tests 😱\n#"
"test": "tsc -p . && tslint -p . && true \n#\n# No tests 😱\n#"
},
"dependencies": {
"@semantic-release/error": "^2.2.0",
"jira-connector": "^2.10.0",
"jira-connector": "^2.16.0",
"lodash": "^4.17.11",
"tslib": "^1.9.2"
},
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -674,10 +674,10 @@ isstream@~0.1.2:
resolved "https://registry.yarnpkg.com/isstream/-/isstream-0.1.2.tgz#47e63f7af55afa6f92e1500e690eb8b8529c099a"
integrity sha1-R+Y/evVa+m+S4VAOaQ64uFKcCZo=

jira-connector@^2.10.0:
version "2.15.7"
resolved "https://registry.yarnpkg.com/jira-connector/-/jira-connector-2.15.7.tgz#fb1aee9f6a16df0f2b8a3c33057b42fdf977efe9"
integrity sha512-tv49hwAdgT4wOOb2j4vAHOQab7kIq0alWN9g0lq6tJgX4WEe/6FlX41x6A5G3TFE7n9JpUXXaJ17volagc2Jcw==
jira-connector@^2.16.0:
version "2.16.0"
resolved "https://registry.yarnpkg.com/jira-connector/-/jira-connector-2.16.0.tgz#1d811c01157574da6431bec4b0b93142ca7c296b"
integrity sha512-h4HYVYZ8Nbq8uiiCMuuY9Lm3sCi4SS1654GSvLS6nqF2/gFCWlmGx+5fEFAVODKXekjwuOUT3kDZpMzO1Uz6mw==
dependencies:
mime-types "^2.1.24"
oauth "^0.9.12"
Expand Down

0 comments on commit d3d0300

Please sign in to comment.