-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
address montonic and prediction size issues #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets merge this, only one change suggested to a comment. Let's close the other PRs as well. Nice one.
Co-authored-by: David Wilby <24752124+davidwilby@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to code description agreed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Happy to merging and close this PR as discussed. Thinking out loud: in dataloader.py perhaps there is a location where we can assert that patched tasks have an equal size in |
This PR addresses the monotonic and prediction size issues. It tries to address these instead of using the previous PRs on this issue: #7 and #6