Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address montonic and prediction size issues #8

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

MartinSJRogers
Copy link
Collaborator

This PR addresses the monotonic and prediction size issues. It tries to address these instead of using the previous PRs on this issue: #7 and #6

Copy link
Owner

@davidwilby davidwilby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge this, only one change suggested to a comment. Let's close the other PRs as well. Nice one.

deepsensor/model/model.py Outdated Show resolved Hide resolved
deepsensor/model/model.py Show resolved Hide resolved
Co-authored-by: David Wilby <24752124+davidwilby@users.noreply.github.com>
Copy link
Collaborator Author

@MartinSJRogers MartinSJRogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to code description agreed.

@davidwilby davidwilby self-requested a review October 15, 2024 12:54
Copy link
Owner

@davidwilby davidwilby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MartinSJRogers
Copy link
Collaborator Author

MartinSJRogers commented Oct 15, 2024

Happy to merging and close this PR as discussed. Thinking out loud: in dataloader.py perhaps there is a location where we can assert that patched tasks have an equal size in x1 and x2?

@davidwilby davidwilby reopened this Oct 15, 2024
@MartinSJRogers MartinSJRogers merged commit 23733df into patchwise_train Oct 15, 2024
5 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants