Add embeddings_ layer and supporting utility functions #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PU & CUDA) and Add `add_to` Parameter
* remove using namespace std from headers * more std:: * more std:: * more std:: on windows stuff * remove uses of using namespace std::chrono * do not use C++17 features * Add Davis suggestion * revert some more stuff * revert removing include * more std::chrono stuff
Cydral
changed the title
|
Is this PR ready for review? It's got conflicts with git master. So not sure if I should be reviewing it yet or not. |
Yes, you can go. I hope that these conflicts, which come (as I mentioned in another thread) from the fact that I've created several branches from my fork to work in parallel on the new Dlib layers, won't overwrite useful changes for certain layers. That said, and if there are compilation problems, I'll obviously fix the few problems, but all the layers currently released are ready for review and integration into the master branch. Thanks in advance. |
davisking
reviewed
Oct 17, 2024
|
Nice, this is cool. Thanks for the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
embeddings_ layer class and adds two new utility functions,embeddings()andembeddings_gradient(), to the tensor_tools.h file. These additions enhance neural network capabilities, particularly for working with LLM-type networks.Key changes: