Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined property: stdClass::$branch #127

Closed
lbailey-ucsf opened this issue Oct 18, 2024 · 1 comment · Fixed by #128
Closed

Undefined property: stdClass::$branch #127

lbailey-ucsf opened this issue Oct 18, 2024 · 1 comment · Fixed by #128

Comments

@lbailey-ucsf
Copy link

During a fresh install of Moodle 4.4.3, Checklist master branch, tag 4.1.0.2, throws "Undefined property: stdClass::$branch" on line 887 of mod/checkist/lib.php, effectively halting the install.

The error occurs during a fresh 4.4.3 install of Moodle on the /user/editadvanced.php page. When installing Moodle 4.3.8 it's a warning.

See screen shot for stack trace.

Screenshot 2024-10-18 at 14-34-09 Whoops! There was an error

Screenshot 2024-10-18 at 10-13-12 This page should automatically redirect  If nothing is happening please use the continue link below  Moodle

@davosmith
Copy link
Owner

That's a very strange error you're getting.

The $CFG->branch value has existed for a long time in Moodle core and, from a quick check through the code is still widely present in the code.

However, I've just done a clean install and can see the error locally.

I've stripped out all the obsolete $CFG->branch checks and will publish a new version of the plugin, once it's passed all the relevant tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants