Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes check for obsolete feature from "supports" callback. #128

Conversation

stopfstedt
Copy link
Contributor

this feature check can be safely removed without replacement at this point.

Moodle 2.8 was a long time ago, this plugin supports Moodle 4.1 and up.

For reference, check the "2.8" section in the upgrade note for activity plugins, here: https://github.com/moodle/moodle/blob/main/mod/upgrade.txt

=== 2.8 ===

  • Constant FEATURE_GROUPMEMBERSONLY is deprecated. Modules should remove this
    constant from their module_supports() API function.
  • $CFG->enablegroupmembersonly no longer exists.

this fixes #127

this feature check can be safely removed without replacement at this
point.
Moodle 2.8 was a long time ago, this plugin supports Moodle 4.1 and up.
For reference, check the "2.8" section in the upgrade note for activity
plugins, here: https://github.com/moodle/moodle/blob/main/mod/upgrade.txt
@davosmith davosmith merged commit f413636 into davosmith:master Oct 19, 2024
5 checks passed
@davosmith
Copy link
Owner

Thanks - nice simple bit of clean-up (doesn't really affect anything much, but always good to clear out redundant old code).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined property: stdClass::$branch
2 participants