Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to ensure that we download the latest artifact #241

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dsnopek
Copy link

@dsnopek dsnopek commented Apr 29, 2023

This fixes issue #240 for me!

When switching from 'listWorkflowRuns' to the 'listWorkflowRunsForRepo' end-point, it's returning the workflow runs in reverse chronological order (ie. newest to oldest), which means that newer artifacts are favored over older ones.

@dsnopek
Copy link
Author

dsnopek commented Apr 29, 2023

Hm, unfortunately, it looks like there's one test failure :-/

@dsnopek
Copy link
Author

dsnopek commented May 17, 2023

Testing this for a little while, it seems to occasionally still pull an artifact that's a couple days old, even though there may be like ~40 newer ones. Adding a new 'ensure_latest' configuration has seemed to fix it in early testing - let's see how this goes!

@dsnopek dsnopek changed the title Switch from 'listWorkflowRuns' to 'listWorkflowRunsForRepo' end-point Attempt to ensure that we download the latest artifact May 17, 2023
@dawidd6
Copy link
Owner

dawidd6 commented May 17, 2023

There is still some regression here. Look at the failed job. Any ideas?

@JacksonBurns
Copy link

JacksonBurns commented Jun 8, 2023

We have also run into this issue here.

This turned out to be user error on our part, I have no comment on the issue at hand.

@dawidd6
Copy link
Owner

dawidd6 commented Aug 11, 2023

@dsnopek are you still working on that?

@ofek
Copy link

ofek commented Sep 16, 2023

Can this be picked up again?

@alberthli
Copy link

+1 on wanting this feature!

Copy link

@lucentlabz lucentlabz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@dawidd6 dawidd6 added help wanted Extra attention is needed good first issue Good for newcomers and removed good first issue Good for newcomers labels Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants