-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature app history #151
Merged
Merged
Feature app history #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shreyas-damle
commented
Feb 14, 2024
- Feature App History
- Code refactoring
rutujaac
previously approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Raj725
reviewed
Feb 14, 2024
Raj725
reviewed
Feb 14, 2024
* added length for snippetCount in report template * pyproject.toml update * remove time conversion function * remove date util dependency * update template to add load history data --------- Co-authored-by: rutujaCopods <rutuja.chaudhary@copods.co>
* App History code changes * Code refactoring for loader doc to make code more modular * Unit tests for loader doc --------- Co-authored-by: Rajendra Kadam <raj.725@outlook.com> Co-authored-by: shreyas.cd <shreyas@clouddefense.io>
* Pydentic DateTime Fix * Key change in report data. * Fixed file count with findings per label. --------- Co-authored-by: shreyas.cd <shreyas@clouddefense.io>
Log change. Co-authored-by: shreyas.cd <shreyas@clouddefense.io>
* added length for snippetCount in report template * pyproject.toml update * remove time conversion function * remove date util dependency * update template to add load history data * update template data mapping --------- Co-authored-by: rutujaCopods <rutuja.chaudhary@copods.co>
* MoreReportsPath Added * Log messages updated. --------- Co-authored-by: shreyas.cd <shreyas@clouddefense.io>
* update template * update load_history["moreReportsPath"]
* discovery load_ids fix * logger mesasge change --------- Co-authored-by: shreyas.cd <shreyas@clouddefense.io>
shreyas-damle
force-pushed
the
feature_app_history
branch
from
February 14, 2024 10:38
7cbfed3
to
229d1d8
Compare
Co-authored-by: shreyas.cd <shreyas@clouddefense.io>
* Add load history json in report template (#106) * added length for snippetCount in report template * pyproject.toml update * remove time conversion function * remove date util dependency * update template to add load history data --------- Co-authored-by: rutujaCopods <rutuja.chaudhary@copods.co> * App History (#109) * App History code changes * Code refactoring for loader doc to make code more modular * Unit tests for loader doc --------- Co-authored-by: Rajendra Kadam <raj.725@outlook.com> Co-authored-by: shreyas.cd <shreyas@clouddefense.io> * Shreyas pydentic datetime fix (#139) * Pydentic DateTime Fix * Key change in report data. * Fixed file count with findings per label. --------- Co-authored-by: shreyas.cd <shreyas@clouddefense.io> * LoadHistory Path Fix (#141) Log change. Co-authored-by: shreyas.cd <shreyas@clouddefense.io> * Load history json template data mapping updated (#143) * added length for snippetCount in report template * pyproject.toml update * remove time conversion function * remove date util dependency * update template to add load history data * update template data mapping --------- Co-authored-by: rutujaCopods <rutuja.chaudhary@copods.co> * MoreReportsPath Added in load history (#144) * MoreReportsPath Added * Log messages updated. --------- Co-authored-by: shreyas.cd <shreyas@clouddefense.io> * fix word wrap and reports display length * show more reports when values are more than 4 --------- Co-authored-by: rutujaCopods <rutuja.chaudhary@copods.co> Co-authored-by: Shreyas Damle <57351398+shreyas-damle@users.noreply.github.com> Co-authored-by: Rajendra Kadam <raj.725@outlook.com> Co-authored-by: shreyas.cd <shreyas@clouddefense.io>
Raj725
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.