Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for mypy ruff linting #190

Merged
merged 4 commits into from
Feb 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/linting.yml
Original file line number Diff line number Diff line change
@@ -31,4 +31,5 @@ jobs:
- name: Pylint
run: |
make lint
make spell_check
10 changes: 8 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -34,11 +34,17 @@ tests:
################################################
# LINT
################################################
PYTHON_FILES=.
MYPY_CACHE=.mypy_cache

lint:
ruff check .
ruff format . --diff
ruff --select I .
mkdir -p $(MYPY_CACHE) && mypy --install-types --non-interactive $(PYTHON_FILES) --cache-dir $(MYPY_CACHE)


spell_check:
codespell --toml pyproject.toml
################################################
# FORMAT
################################################
@@ -60,4 +66,4 @@ help:
@echo 'tests TEST_FILE=<test_file> - run all tests in file'


.PHONY: all clean build install test tests help
.PHONY: all clean build install test tests help lint spell_check
2 changes: 2 additions & 0 deletions tests/test_requirements.txt
Original file line number Diff line number Diff line change
@@ -6,3 +6,5 @@ httpx==0.26.0
pytest==8.0.0
pytest-mock==3.12.0
ruff
mypy
codespell