Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruff and pylint fixes for pebblo/app module #236

Merged
merged 9 commits into from
Mar 1, 2024
Merged

Ruff and pylint fixes for pebblo/app module #236

merged 9 commits into from
Mar 1, 2024

Conversation

shreyas-damle
Copy link
Collaborator

@shreyas-damle shreyas-damle commented Feb 27, 2024 •
edited
Loading

  • Fixed ruff and pylint issues for pebblo/app module and tests/app module.
  • All unit tests are passing.
  • There are few ruff fixes showing up on the github workflow, which were not being shown locally. I will fix them in the follow up PR in order to get this PR merged quickly to avoid conflicts for other team members,

@shreyas-damle shreyas-damle marked this pull request as ready for review February 28, 2024 14:07
Raj725
Raj725 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@Raj725 Raj725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shreyas-damle shreyas-damle merged commit 884c2cf into daxa-ai:main Mar 1, 2024
16 of 20 checks passed
@shreyas-damle shreyas-damle deleted the shreyas-ruff-fixes branch March 7, 2024 06:48
shreyas-damle added a commit to shreyas-damle/pebblo that referenced this pull request Apr 24, 2024
@shreyas-damle
Ruff and pylint fixes for pebblo/app module (daxa-ai#236)
b82bcf8 
* ruff formating and pylint fixes for pebblo/app module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raj725 Raj725 Raj725 approved these changes

@srics srics Awaiting requested review from srics

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreyas-damle @Raj725