Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for showing pebblo server and client version on DAXA UI. #319

Merged

Conversation

dristysrivastava
Copy link
Collaborator

@dristysrivastava dristysrivastava commented Apr 11, 2024

Sending ai_apps data including pebbloServerVersion and pebbloClientVersion in v1/app/discover API
Updated UTs as well

…ted UTs as well
@dristysrivastava dristysrivastava requested review from Raj725 and shreyas-damle and removed request for Raj725 April 11, 2024 06:05
@dristysrivastava dristysrivastava self-assigned this Apr 11, 2024
@dristysrivastava dristysrivastava changed the title Changes for showing pebblo server and client version on DAXA UI. Upda… Changes for showing pebblo server and client version on DAXA UI. Apr 11, 2024
@dristysrivastava dristysrivastava marked this pull request as ready for review April 12, 2024 04:12
@srics
Copy link
Collaborator

srics commented Apr 12, 2024

Hold until after 0.1.14 release

@dristysrivastava dristysrivastava requested a review from srics April 15, 2024 06:33
Copy link
Collaborator

@shreyas-damle shreyas-damle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the comments on #315 are already incorporated, approving this PR.

@shreyas-damle shreyas-damle merged commit 30c05ef into daxa-ai:main Apr 16, 2024
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants