Added keyword to string mapping in reports and ui #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "financial-report": "Financial Report", | ||
| "loan-and-security-agreement ": "Loan And Security Agreement", | ||
| "merger-agreement": "Merger Agreement", | ||
| nda: "NDA", |
There was a problem hiding this comment.
Why this nda is without quotes?
There was a problem hiding this comment.
Since "nda" is a single (no space) object key, the quotes do not appear on it. We only need quotes around object keys if there are multiple words separated by a space.
shreyas-damle
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following topic & entity keyword to name mapping in Reports and UI:
"normal-text": "Normal Text",
"medical-advice": "Medical Advice",
"harmful-advice": "Harmful Advice",
"board-meeting": "Board Meeting",
"consulting-agreement": "Consulting Agreement",
"customer-list": "Customer List",
"distribution/partner-agreement": "Distribution/Partner Agreement",
"enterprise-agreement": "Enterprise Agreement",
"executive-severance-agreement": "Executive Severance Agreement",
"financial-report": "Financial Report",
"loan-and-security-agreement ": "Loan And Security Agreement",
"merger-agreement": "Merger Agreement",
nda: "NDA",
"patent-application-fillings": "Patent Application Fillings",
"price-list": "Price List",
"settlement-agreement": "Settlement Agreement",
"sexual-harassment": "Sexual Harassment",
"employee-agreement": "Employee Agreement",
"us-ssn": "US SSN",
"us-passport-number": "US Passport number",
"us-drivers-license": "US Drivers License",
"credit-card-number": "Credit card number",
"us-bank-account-number": "US Bank Account Number",
"iban-code": "IBAN code",
"us-itin": "US ITIN",
"github-token": "Github Token",
"slack-token": "Slack Token",
"aws-access-key": "AWS Access Key",
"aws-secret-key": "AWS Secret Key",
"azure-key-id": "Azure Key ID",
"azure-client-secret": "Azure Client Secret",
"google-api-key": "Google API Key"
NOTE: Ensured backward compatibility - if complete string like "AWS Secret Key" is found instead of keyword "aws-secret-key", original string is rendered.