Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharepoint loader #361

Closed
wants to merge 3 commits into from
Closed

Conversation

arpitkumar980
Copy link

No description provided.

@srics srics requested a review from Raj725 April 30, 2024 05:19
@Raj725
Copy link
Collaborator

Raj725 commented Apr 30, 2024

@arpitkumar980 Do we need to set any env variables to run these samples?

Copy link
Collaborator

@Raj725 Raj725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a basic README

def load_documents(self):
print("\nLoading RAG documents ...")
loader = PebbloSafeLoader(
SharePointLoader(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have these samples been tested? I am getting the following error on this line:

pebblo/pebblo_safeloader/langchain/identity-rag-sharepoint/pebblo_identity_safeload_sharepoint.py", line 30, in load_documents
      SharePointLoader(
  File "pydantic/main.py", line 339, in pydantic.main.BaseModel.__init__
  File "pydantic/main.py", line 1066, in pydantic.main.validate_model
  File "pydantic/fields.py", line 439, in pydantic.fields.ModelField.get_default
  File "pydantic/env_settings.py", line 39, in pydantic.env_settings.BaseSettings.__init__
  File "pydantic/main.py", line 341, in pydantic.main.BaseModel.__init__
pydantic.error_wrappers.ValidationError: 2 validation errors for _O365Settings
client_id
  field required (type=value_error.missing)
client_secret
  field required (type=value_error.missing)

@arpitkumar980
Copy link
Author

yes we need config for this

Copy link
Collaborator

@Raj725 Raj725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the samples to match the latest sample in the main branch, test it, and then we can merge this PR.

"""
Initialize PebbloRetrievalQA chain
"""
return PebbloRetrievalQA.from_chain_type(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arpitkumar980 Update the initialization of PebbloSafeLoader and PebbloRetrievalQA to match the latest sample in the main branch, and then we can merge this PR.

@srics
Copy link
Collaborator

srics commented Jun 18, 2024

Superseded by #399. Closing.

@srics srics closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants