Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed version error in case of empty clientVersion #501

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Fixed version error in case of empty clientVersion #501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pebblo/reports/html_to_pdf_generator/report_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def convert_html_to_pdf(data, output_path, template_name, search_path, renderer)
findings_count = data["reportSummary"].get("findings", 0)
clientVersion = ""
versionObj = data.get("clientVersion", None)
if versionObj is not None and versionObj["version"] is not None:
if versionObj is not None and versionObj.get("version", None) is not None:
clientVersion = (
versionObj.get("name", "") + " " + versionObj.get("version", "")
)
Expand Down