Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/#514 move weasyprint dependency check to config validation #524

Merged
merged 7 commits into from
Sep 1, 2024
Merged

Bugfix/#514 move weasyprint dependency check to config validation #524

merged 7 commits into from
Sep 1, 2024

Conversation

aramnhammer
Copy link
Contributor

fixes #514:

  • moves checks for weasyprint to config_validation.py
  • opts for using importlib.util.find_spec to check for package spec, instead of importing

@srics srics force-pushed the bugfix/#514_move-weasyprint-dependency-check-to-config-validation branch from 230c9ec to 6e3b865 Compare September 1, 2024 03:23
@srics srics merged commit 59a9834 into daxa-ai:main Sep 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srics srics srics approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move weasyprint dependency pkg check to config validation
2 participants
@aramnhammer @srics