Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-config와 tsconfig에 대한 배포 github action #13

Merged
merged 9 commits into from
Dec 26, 2022

Conversation

rageatm
Copy link
Contributor

@rageatm rageatm commented Dec 22, 2022

PR 의 종류는 어떤 것인가요?

  • 버그 수정
  • 새로운 기능
  • 리팩토링
  • 문서 수정
  • 워크플로우 수정

수정이 필요하게된 이유가 무엇인가요? (Jira 이슈가 있다면 링크를 연결해주세요)

#2

무엇을 어떻게 변경했나요?

  1. 코드의 변경과 상관없이 package.json이 변경되면 배포 대상인 것으로 여긴다
  2. stylelint-config에 대한 배포 github action은 repo 이전 문제가 해결된 후에 추가한다.

코드 변경을 이해하기 위한 배경지식이 필요하다면 설명 해주세요.

체크아웃->node 설치->npm ci->npm publish

디펜던시 변경이 있나요?

어떻게 테스트 하셨나요?

대상 브랜치를 변경하여 해당 브랜치에서 action이 제대로 동작하는지 확인
https://github.com/day1co/standards/actions

코드의 실행결과를 볼 수 있는 로그가 있다면 첨부해주세요.

@rageatm rageatm self-assigned this Dec 22, 2022
@rageatm rageatm requested review from iolo and a team December 22, 2022 08:39
@@ -0,0 +1,14 @@
#!/bin/bash

slackToDeptDev() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.blog/changelog/2022-12-06-github-actions-workflow-notifications-in-slack-and-microsoft-teams/
메시지를 커스텀할 목적이 아니라면... 이제 더이상 필요없습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이것은 #github-notify인가 #npm-publish-notify인가......

@rageatm rageatm marked this pull request as ready for review December 23, 2022 02:32
@rageatm rageatm requested a review from iolo December 23, 2022 02:35
Copy link
Contributor

@iolo iolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@rageatm rageatm merged commit 83085cd into main Dec 26, 2022
@rageatm rageatm deleted the github-action branch December 26, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants