Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip to horizontal-bar-tabs & :validate? #199

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

PawelStroinski
Copy link
Contributor

The new attributes:

  • :tooltip-fn [horizontal-bar-tabs only] given an element of :tabs, returns its tooltip
  • :tooltip-position [horizontal-bar-tabs only] relative to this anchor. One of :above-left, :above-center, :above-right, :below-left, :below-center, :below-right, :left-above, :left-center, :left-below, :right-above, :right-center, :right-below
  • :validate? [horizontal-bar-tabs & vertical-bar-tabs only] validate :model against :tabs (true by default as this is the current behaviour)

The Tooltips demo has been added as well.

The new attributes:

* `:tooltip-fn`          [horizontal-bar-tabs only] given an element of :tabs, returns its tooltip
* `:tooltip-position`    [horizontal-bar-tabs only] relative to this anchor. One of :above-left, :above-center, :above-right, :below-left, :below-center, :below-right, :left-above, :left-center, :left-below, :right-above, :right-center, :right-below
* `:validate?`           [horizontal-bar-tabs & vertical-bar-tabs only] validate :model against :tabs (true by default as this is the current behaviour)

The [Tooltips demo](https://pawelstroinski.github.io/re-com/#/tabs) has been added as well.
@superstructor
Copy link
Contributor

Thanks @PawelStroinski 👍 😄

Tested locally via demos page and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants