React 18 #391
Merged
React 18 #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React 18 introduces a new render API: https://react.dev/blog/2022/03/29/react-v18#react-dom-client The reagent.dom.client namespace wraps this new API. reagent.dom still wraps the old one. React throws a deprecation warning if you use the old API with React 18. If a user uses the new API in their project, they will still get the warning because of re-frame-10x using the old API. This is confusing. It looks as if their code is suspect, when actually ours is. re-frame-10x depends on the user's react version. That means we can't predict whether the user will use React 17 or React 18, or which API they will invoke. We can't just load reagent.dom.client, because it only works with React 18. We can't load it conditionally based on the react version, since it's a general limitation of cljs that we can't require a namespace at runtime. Added a second preload namespace. Since only the user can know which API to use, we let them declare it themselves. The original preload remains unchanged: {:preloads [day8.re-frame-10x.preload]} It calls the old API, which works in all cases. It throws the deprecation warning if the user has React 18. The new preload only works with React 18, using the new API properly: {:preloads [day8.re-frame-10x.preload.react-18]} Fixes #367
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.