Avoid running after/enrich without a db effect #511
Merged
+54
−48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously both standard interceptors acted upon the
db
coeffect ifno effect was available. Per #453 and related discussion, there is little
reason in general to do this, since this context means that the
app-db
should not change.
Both functions are changed to explicitly check for the presence of the
db
effect. If it is not present in the context, the interceptorfunction is not run.
The previous functionality around
nil
andfalse
values for thedb
effect is preserved: the interceptors are run in this case. Tests are
added where needed to verify the behavior of both functions in the case
of non-present, falsey and truthy values.
The relevant docstrings are tweaked to accommodate this change.
Closes #453.