Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical line always selected even if not within selection #117

Closed
m-damien opened this issue Jan 8, 2023 · 2 comments
Closed

Vertical line always selected even if not within selection #117

m-damien opened this issue Jan 8, 2023 · 2 comments
Labels
bug Something isn't working complete
Milestone

Comments

@m-damien
Copy link

m-damien commented Jan 8, 2023

Environments

Description

Thank you for this library, it has been a pleasure to work with it so far!
I am having an issue with vertical SVG lines. They seem to be getting selected even when they are not part of the selection:
line_selection
I was able to reproduce the issue starting from one of the examples from the Storybook (see the testable address above). Seems to be fine with horizontal line, or lines that are not perfectly vertical.

daybrush added a commit that referenced this issue Jan 11, 2023
@daybrush daybrush added this to the 1.21.0 milestone Jan 11, 2023
@daybrush daybrush added the bug Something isn't working label Jan 11, 2023
@daybrush
Copy link
Owner

@m-damien

  • lit-selecto 1.21.0
  • preact-selecto 1.18.0
  • react-selecto 1.21.0
  • selecto 1.21.0
  • svelte-selecto 1.21.0
  • vue-selecto 1.21.0
  • vue3-selecto 1.7.0
  • ngx-selecto 1.21.0

selecto's new version is released.

Check it again.

@m-damien
Copy link
Author

That was impressively quick! I tried the new version, the problem is completely fixed.

Thanks heaps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working complete
Projects
None yet
Development

No branches or pull requests

2 participants