forked from ibttf/interview-coder
-
Notifications
You must be signed in to change notification settings - Fork 50
Main #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gamidirohan
wants to merge
34
commits into
daydiff:master
Choose a base branch
from
gamidirohan:main
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Main #3
+5,906
−1,520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity is displayed.
…mplecity is displayed.
…code, debug_analysis and so on....
This commit adds: 1. A new CopyButton component that allows users to easily copy code with proper indentation 2. Integration of the copy button in all code sections in both Solutions and Debug pages 3. Styling that matches the dark theme with translucent background Known issues that still need to be addressed: - Window resizing not working correctly - the application window doesn't properly resize to match content - Need to investigate how content dimensions are communicated to the main process
…esponse is visible on screen
BREAKING CHANGES: - Completely refactored from interview-coder app to conversational co-pilot - Removed all legacy screenshot/interview-coder functionality - Transformed UI into horizontal floating window with glass-morphism design Core Features: - Floating window: 1920x500 default, centered, rounded corners, taskbar invisible - Responsive design: Desktop (16:9) and mobile (9:16) aspect ratios - Window scaling: Ctrl +/- to resize entire window (not content zoom) - Window movement: Ctrl + Arrow keys for keyboard navigation - Glass-morphism dark theme with modern UI components Files Modified: - electron/main.ts: Complete window management rewrite with scaling/movement logic - electron/preload.ts: Updated IPC API for new co-pilot functionality - electron/ipcHandlers.ts: Added window scaling and movement IPC handlers - electron/shortcuts.ts: Added keyboard shortcuts for window control - src/App.tsx: Complete UI rewrite with responsive floating dock navigation - src/types/electron.d.ts: Updated type definitions for new IPC events - package.json: Updated app metadata and dependencies New Components: - src/components/ui/floating-dock.tsx: Floating navigation dock component - src/components/main-layout.tsx: Main layout wrapper with responsive design Documentation: - TASKS.md: Detailed task breakdown and progress tracking - FLOATING_WINDOW_README.md: Technical documentation for window features Legacy Code Removal: - All screenshot/interview-coder UI components and logic removed - Replaced with modern chat interface and speech visualization - Removed Queue/Solutions/Debug pages, replaced with conversational UI
FIXES: - Window scaling now respects 1382x777 as true 1.0x maximum - Prevent scaling beyond 1.0x (show 'Already at maximum' message) - Fix window movement with proper keyboard shortcuts (Ctrl + Arrow keys) - Add scaling debounce to prevent choppy resize behavior - Improve scale-to-actual-size correlation CHANGES: - electron/main.ts: * Update originalWidth/Height to 1382x777 (actual displayable maximum) * Add scaleWindow function with proper bounds checking * Implement window movement functions with screen constraints * Add isTogglingVisibility flag to prevent resize loops during show/hide * Improve setWindowDimensions with better debouncing and thresholds - electron/shortcuts.ts: * Add missing keyboard shortcuts for window movement (Ctrl + Arrow keys) * Fix scale shortcuts to use window scaling instead of content zoom * Add scale debouncing to prevent rapid-fire scaling issues TECHNICAL DETAILS: - Scale factor now directly correlates with visual window size - Eliminated 'phantom scaling' where scale changed but window didn't - Window movement uses proper boundary checking - Added comprehensive logging for debugging scaling issues
PROBLEM SOLVED: - Eliminated endless 'Window dimensions updated' spam when window loses focus - Fixed architectural issue where ResizeObserver fired continuously regardless of focus state SOLUTION APPROACH: - Move from 'filter-at-destination' to 'control-at-source' architecture - Enable/disable ResizeObserver based on window focus state instead of checking focus on every resize CHANGES: - src/App.tsx: * Replace always-active ResizeObserver with focus-aware ResizeObserver * Add window focus/blur event listeners * Enable ResizeObserver only when window is focused * Disable ResizeObserver completely when window loses focus * Add proper cleanup for event listeners and observer TECHNICAL BENEFITS: - No IPC calls when window is out of focus - Better performance (less processing when inactive) - Cleaner logs (no spam when unfocused) - Architectural improvement: event source control vs event filtering BEFORE: ResizeObserver fires IPC calls Electron rejects Waste processing AFTER: Window unfocused ResizeObserver disabled No IPC calls Clean architecture
…sation history - Merged code mode UI back into App.tsx from separate CodePage - Implemented conversational AI chat interface for solutions - Fixed window opacity handling (Ctrl+] now works properly) - Added invisible scrollbars for clean UI - Created conversation history state for user/AI messages - Removed duplicate imports and old components Known issues: - Layout stretching: right side speech widgets stretched, input area pushed out of view - Duplicate rendering: 'Code Analysis' text appears twice - Scroll container height needs adjustment to fit within window bounds
…on of UI and a few shortcuts, modularised components and nav bar. Not Completed: Backend; Window movement with shortcuts; Actual Brain Page implementation
- Fix window movement controls (add isMoving flag) - Prevent accidental transparency (increase min opacity 0.10.3) - Auto-restore opacity after solution generation - Enhance CodePage with explanation and complexity details - Add opacity shortcut hints and debug info
… STT is working for user end mic, other side to be fixed/ implemented. Also, End point port numbers fixed to accomodate webhooks and rest of the server to work toegther.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.