Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genesis 9 AutoIK support #48

Open
danielbui78 opened this issue Jan 24, 2023 · 3 comments
Open

Genesis 9 AutoIK support #48

danielbui78 opened this issue Jan 24, 2023 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request fixed Issue is resolved.

Comments

@danielbui78
Copy link
Contributor

Genesis 9 figures crash during joint fix and AutoIK functions.

Hotfix in progress...

@danielbui78 danielbui78 added bug Something isn't working enhancement New feature or request labels Jan 24, 2023
@danielbui78 danielbui78 self-assigned this Jan 24, 2023
@joaomonteirolcc
Copy link

Hi,
I'm so happy to have found this ticker.
I've been trying for 2 days to import a recently made genesis 9 characters and couldn't understand why the auto-IK crashed (or simply stopped by only creating a couple of Nulls in c4d). I htought it wasn't compatible with c4d 2023.
Appreciate you looking at it, thanks. Do you think this will be a quick fix, or months?
Just need to assess if I should create a different character for my project.
Thank you
Joao Monteiro

babebridou added a commit to babebridou/DazToC4D that referenced this issue Feb 19, 2023
babebridou added a commit to babebridou/DazToC4D that referenced this issue Feb 19, 2023
@babebridou
Copy link
Contributor

babebridou commented Feb 19, 2023

I'm not sure if this is helpful or not since you are working on it, but I've gone and done a quick (but large) refactor to at least fix the crash with auto IK for genesis 9 figures, using a genesis 9 database and a dictionary to convert the various bone and joint names.

basically all I did was replace every single hardcoded bone, joint or IK reference with a query to a dictionary using the existing label. If the model is identified as a Genesis 9 model, it then goes through a mapping. If not, it's used "as is", so that the refactor does not break previous gen8 models. There were a number of issues since a lot of the autoIK involves partial references to deal with left and right and automatic joint mapping, and things are kind of iffy with fingers and toes, so the mapping is non-trivial.

It's still kind of hacky, there are probably issues with constraints and code quality but at least the process completes and the IKs seem to be kind of working on genesis 9.

link to the commit, should I open a pull request?

@danielbui78 danielbui78 added the fixed Issue is resolved. label Mar 14, 2023
@danielbui78
Copy link
Contributor Author

G9 AutoIK support now working in latest release: https://github.com/daz3d/DazToC4D/releases/tag/2022.2.13

@babebridou Due to time constraints, I was not able to merge your full branch, but did incorporate a few improvements. I will try to revisit the other changes in the future as time permits. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request fixed Issue is resolved.
Projects
None yet
Development

No branches or pull requests

3 participants